* [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC
@ 2020-08-14 2:08 Zejiang Tang
2020-08-14 2:17 ` Steven Rostedt
2020-08-14 2:22 ` Florian Fainelli
0 siblings, 2 replies; 4+ messages in thread
From: Zejiang Tang @ 2020-08-14 2:08 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar, Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel
There exists redundant #ifdef CONFIG_DYNAMIC_FTRAC in ftrace.c, remove it.
Signed-off-by: Zejiang Tang <tangzejiang@loongson.cn>
---
arch/mips/kernel/ftrace.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
index 2625232..f57e68f 100644
--- a/arch/mips/kernel/ftrace.c
+++ b/arch/mips/kernel/ftrace.c
@@ -37,10 +37,6 @@ void arch_ftrace_update_code(int command)
ftrace_modify_all_code(command);
}
-#endif
-
-#ifdef CONFIG_DYNAMIC_FTRACE
-
#define JAL 0x0c000000 /* jump & link: ip --> ra, jump to target */
#define ADDR_MASK 0x03ffffff /* op_code|addr : 31...26|25 ....0 */
#define JUMP_RANGE_MASK ((1UL << 28) - 1)
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC
2020-08-14 2:08 [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC Zejiang Tang
@ 2020-08-14 2:17 ` Steven Rostedt
2020-08-14 2:22 ` Florian Fainelli
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2020-08-14 2:17 UTC (permalink / raw)
To: Zejiang Tang; +Cc: Ingo Molnar, Thomas Bogendoerfer, linux-mips, linux-kernel
On Fri, 14 Aug 2020 10:08:15 +0800
Zejiang Tang <tangzejiang@loongson.cn> wrote:
> There exists redundant #ifdef CONFIG_DYNAMIC_FTRAC in ftrace.c, remove it.
>
> Signed-off-by: Zejiang Tang <tangzejiang@loongson.cn>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> ---
> arch/mips/kernel/ftrace.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
> index 2625232..f57e68f 100644
> --- a/arch/mips/kernel/ftrace.c
> +++ b/arch/mips/kernel/ftrace.c
> @@ -37,10 +37,6 @@ void arch_ftrace_update_code(int command)
> ftrace_modify_all_code(command);
> }
>
> -#endif
> -
> -#ifdef CONFIG_DYNAMIC_FTRACE
> -
> #define JAL 0x0c000000 /* jump & link: ip --> ra, jump to target */
> #define ADDR_MASK 0x03ffffff /* op_code|addr : 31...26|25 ....0 */
> #define JUMP_RANGE_MASK ((1UL << 28) - 1)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC
2020-08-14 2:08 [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC Zejiang Tang
2020-08-14 2:17 ` Steven Rostedt
@ 2020-08-14 2:22 ` Florian Fainelli
2020-08-14 2:27 ` Zejiang Tang
1 sibling, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2020-08-14 2:22 UTC (permalink / raw)
To: Zejiang Tang, Steven Rostedt, Ingo Molnar, Thomas Bogendoerfer
Cc: linux-mips, linux-kernel
On 8/13/2020 7:08 PM, Zejiang Tang wrote:
> There exists redundant #ifdef CONFIG_DYNAMIC_FTRAC in ftrace.c, remove it.
There is a missing E at the end of CONFIG_DYNAMIC_FTRAC in your subject
FWIWW.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC
2020-08-14 2:22 ` Florian Fainelli
@ 2020-08-14 2:27 ` Zejiang Tang
0 siblings, 0 replies; 4+ messages in thread
From: Zejiang Tang @ 2020-08-14 2:27 UTC (permalink / raw)
To: Florian Fainelli
Cc: Steven Rostedt, Ingo Molnar, Thomas Bogendoerfer, linux-mips,
linux-kernel
ok，thank you very much
"Florian Fainelli" <f.fainelli@gmail.com>wrote:
>
>
> On 8/13/2020 7:08 PM, Zejiang Tang wrote:
> > There exists redundant #ifdef CONFIG_DYNAMIC_FTRAC in ftrace.c, remove it.
>
> There is a missing E at the end of CONFIG_DYNAMIC_FTRAC in your subject
> FWIWW.
> --
> Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-14 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 2:08 [PATCH] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRAC Zejiang Tang
2020-08-14 2:17 ` Steven Rostedt
2020-08-14 2:22 ` Florian Fainelli
2020-08-14 2:27 ` Zejiang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).