From: Marc Zyngier <maz@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-mips@vger.kernel.org, chenhc@lemote.com
Subject: Re: [RFC PATCH 0/6] MIPS: Handle CPU IRQ in domain's way
Date: Thu, 26 Mar 2020 15:46:37 +0000 [thread overview]
Message-ID: <7c179c74ec54a5a00c8cc9227f094868@kernel.org> (raw)
In-Reply-To: <20200326153849.GA14951@alpha.franken.de>
On 2020-03-26 15:38, Thomas Bogendoerfer wrote:
> On Thu, Mar 26, 2020 at 02:16:56PM +0800, Jiaxun Yang wrote:
>> In [1], we discussed about why MIPS CPU IRQ doesn't fit simple IRQ
>> domain.
>> I felt it's time to remove this barrier and "modernize" the whole
>> flow.
>>
>> This set is simply a proof of concept of removing the whole
>> MIPS_CPU_IRQ_BASE
>> and use the irq_domain's way.
>>
>> Currently only Loongson64 and ip22 are adapted for testing purpose,
>> if everybody is happy with it, then I'll take a look at more
>> platforms.
>>
>> Btw: Thomas, are you still willing to drop some platforms in 5.8?
>
> yes, I didn't receive feedback to not drop them. So after merge
> window is over I'm going to post a patch to remove LASAT, NEC_MARKEINS
> and PMC_MSP.
>
>> arch/mips/include/asm/irq_cpu.h | 19 +++++++++++++++++-
>> arch/mips/include/asm/sgi/ip22.h | 30
>> ++++++++++++++--------------
>> arch/mips/kernel/cevt-r4k.c | 2 +-
>> arch/mips/kernel/perf_event_mipsxx.c | 3 ++-
>> arch/mips/kernel/rtlx-mt.c | 7 +++++--
>> arch/mips/loongson64/smp.c | 6 ++++--
>> arch/mips/sgi-ip22/ip22-int.c | 14 ++++++++-----
>> drivers/irqchip/irq-mips-cpu.c | 22 ++++++++++++++------
>> 8 files changed, 70 insertions(+), 33 deletions(-)
>
> Adding more code for doing the same thing doesn't sound like the
> best approach. Is there a big need for that change (like someone
> getting rid of irq_domain_add_legacy) ?
I have no plan to remove the API overnight, but if you guys start
modernizing MIPS, I could be tempted...
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2020-03-26 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 6:16 [RFC PATCH 0/6] MIPS: Handle CPU IRQ in domain's way Jiaxun Yang
2020-03-26 6:16 ` [RFC PATCH 1/6] MIPS: irq_cpu: Add a helper to map virq for CPU IRQ Jiaxun Yang
2020-03-26 6:16 ` [PATCH 1/2] MIPS: Kill MIPS_GIC_IRQ_BASE Jiaxun Yang
2020-03-26 6:16 ` [RFC PATCH 2/6] irqchip: mips-cpu: Allocate fwnode for non-DT platforms Jiaxun Yang
2020-03-26 6:17 ` [PATCH 2/2] MIPS: Kill RM7K & RM9K IRQ Code Jiaxun Yang
2020-03-26 6:17 ` [RFC PATCH 3/6] irqchip: mips-cpu: Convert to simple domain Jiaxun Yang
2020-03-26 6:17 ` [RFC PATCH 4/6] MIPS: kernel: Use mips_cpu_map_virq helper Jiaxun Yang
2020-03-26 6:17 ` [RFC PATCH 5/6] MIPS: loongson64: " Jiaxun Yang
2020-03-26 6:20 ` [RFC PATCH 6/6] MIPS: ip22: " Jiaxun Yang
2020-03-26 15:38 ` [RFC PATCH 0/6] MIPS: Handle CPU IRQ in domain's way Thomas Bogendoerfer
2020-03-26 15:46 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c179c74ec54a5a00c8cc9227f094868@kernel.org \
--to=maz@kernel.org \
--cc=chenhc@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).