Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] lib: vdso: mark __cvdso_clock_getres() as static
@ 2020-01-11 17:48 Christophe Leroy
  2020-01-11 19:59 ` Thomas Gleixner
  0 siblings, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2020-01-11 17:48 UTC (permalink / raw)
  To: arnd, tglx, vincenzo.frascino, luto
  Cc: linux-kernel, linuxppc-dev, linux-arm-kernel, linux-mips, x86

When __cvdso_clock_getres() became __cvdso_clock_getres_common()
and a new __cvdso_clock_getres() was added, static qualifier was
forgotten.

Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 lib/vdso/gettimeofday.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index 9ecfd3b547ba..42bd8ab955fa 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -221,6 +221,7 @@ int __cvdso_clock_getres_common(clockid_t clock, struct __kernel_timespec *res)
 	return 0;
 }
 
+static __maybe_unused
 int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res)
 {
 	int ret = __cvdso_clock_getres_common(clock, res);
-- 
2.13.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static
  2020-01-11 17:48 [PATCH] lib: vdso: mark __cvdso_clock_getres() as static Christophe Leroy
@ 2020-01-11 19:59 ` Thomas Gleixner
  2020-01-13 12:04   ` Christophe Leroy
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2020-01-11 19:59 UTC (permalink / raw)
  To: Christophe Leroy, arnd, vincenzo.frascino, luto
  Cc: linux-kernel, linuxppc-dev, linux-arm-kernel, linux-mips, x86

Christophe Leroy <christophe.leroy@c-s.fr> writes:
> When __cvdso_clock_getres() became __cvdso_clock_getres_common()
> and a new __cvdso_clock_getres() was added, static qualifier was
> forgotten.
>
> Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

I've already queued:

     https://lore.kernel.org/r/20191128111719.8282-1-vincenzo.frascino@arm.com

but thanks for caring!

Thanks,

        tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static
  2020-01-11 19:59 ` Thomas Gleixner
@ 2020-01-13 12:04   ` Christophe Leroy
  2020-01-13 15:08     ` Thomas Gleixner
  0 siblings, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2020-01-13 12:04 UTC (permalink / raw)
  To: Thomas Gleixner, arnd, vincenzo.frascino, luto
  Cc: linux-kernel, linuxppc-dev, linux-arm-kernel, linux-mips, x86



Le 11/01/2020 à 20:59, Thomas Gleixner a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> When __cvdso_clock_getres() became __cvdso_clock_getres_common()
>> and a new __cvdso_clock_getres() was added, static qualifier was
>> forgotten.
>>
>> Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> 
> I've already queued:
> 
>       https://lore.kernel.org/r/20191128111719.8282-1-vincenzo.frascino@arm.com
> 
> but thanks for caring!
> 


Is there a git tree with the latest VDSO status ?

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso 
is 6 monthes old.

Christophe

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static
  2020-01-13 12:04   ` Christophe Leroy
@ 2020-01-13 15:08     ` Thomas Gleixner
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2020-01-13 15:08 UTC (permalink / raw)
  To: Christophe Leroy, arnd, vincenzo.frascino, luto
  Cc: linux-kernel, linuxppc-dev, linux-arm-kernel, linux-mips, x86

Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Is there a git tree with the latest VDSO status ?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso 
> is 6 monthes old.

Will push a new one later today. I'll let you know.

Thanks,

        tglx


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-11 17:48 [PATCH] lib: vdso: mark __cvdso_clock_getres() as static Christophe Leroy
2020-01-11 19:59 ` Thomas Gleixner
2020-01-13 12:04   ` Christophe Leroy
2020-01-13 15:08     ` Thomas Gleixner

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git