Re: [PATCH 5/8 v2] MIPS: ralink: mt7628a.dtsi: Add I2C controller DT node

[Stefan Roese <sr@denx.de>]

Hi Paul,

On 28.05.19 22:41, Paul Burton wrote:
> Hi Stefan,
> 
> On Mon, May 27, 2019 at 11:13:20AM +0200, Stefan Roese wrote:
>> diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi
>> index 0c2983c9c47c..64a425c7d639 100644
>> --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi
>> +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi
>> @@ -170,6 +170,22 @@
>>   			interrupts = <6>;
>>   		};
>>   
>> +		i2c: i2c@900 {
>> +			compatible = "mediatek,mt7621-i2c";
>> +			reg = <0x900 0x100>;
> 
> I don't see this compatible string listed under
> Documentation/devicetree/bindings, nor in
> drivers/i2c/busses/i2c-mt65xx.c which I presume is the driver that would
> handle it.

No, these is a different driver queued for this (old) SoC. I've submitted
it on the I2C list and am pretty hopeful, that it will hit next shortly:

https://patchwork.ozlabs.org/patch/1095794/

The bindings are included in this patch.
  
> I guess this needs driver changes to be applied before it'll actually do
> anything?

Correct.
  
> I'd prefer that at least the DT binding documentation goes in before we
> add the nodes to the DT.

I understand. I've added Wolfram to Cc to perhaps comment on this.
  
> If those changes are already queued up somewhere else could you point me
> at them?

Please see above.

Thanks,
Stefan