From: Stefan Roese <sr@denx.de>
To: Paul Burton <paul.burton@mips.com>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH 8/8 v2] MIPS: ralink: Add GARDENA smart Gateway MT7688 board
Date: Tue, 25 Jun 2019 07:31:00 +0200 [thread overview]
Message-ID: <c102edbb-c322-28e7-0b98-54e446ce1872@denx.de> (raw)
In-Reply-To: <20190624212959.he2xf4pkm35c7k53@pburton-laptop>
Hi Paul,
On 24.06.19 23:30, Paul Burton wrote:
> On Mon, May 27, 2019 at 11:13:23AM +0200, Stefan Roese wrote:
>> This patch adds support for the GARDENA smart Gateway, which is based on
>> the MediaTek MT7688 SoC. It is equipped with 128 MiB of DDR and 8 MiB of
>> flash (SPI NOR) and additional 128MiB SPI NAND storage.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Paul Burton <paul.burton@mips.com>
>> Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
>> Cc: John Crispin <john@phrozen.org>
>> ---
>> v2:
>> - Use Harvey's new email address (not at imgtec)
>> - Use correct linux-mips list address
>>
>> .../ralink/gardena_smart_gateway_mt7688.dts | 196 ++++++++++++++++++
>> 1 file changed, 196 insertions(+)
>> create mode 100644 arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts
>
> Thanks for the patch - this one sees checkpatch complain about the
> Gardena DT vendor prefix being undocumented, as well as the board
> compatible string:
>
> WARNING: DT compatible string "Gardena,smartGatewayMT7688" appears un-documented -- check ./Documentation/devicetree/bindings/
> #40: FILE: arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:14:
> + compatible = "Gardena,smartGatewayMT7688", "ralink,mt7628a-soc";
>
> WARNING: DT compatible string vendor "Gardena" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
> #40: FILE: arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:14:
> + compatible = "Gardena,smartGatewayMT7688", "ralink,mt7628a-soc";
>
> Could you add the entry to
> Documentation/devicetree/bindings/vendor-prefixes.yaml & a short
> description of the board somewhere like
> Documentation/devicetree/bindings/mips/ralink/gardena.txt?
Sure, I'll send a new version of this patch with these additions.
Thanks,
Stefan
next prev parent reply other threads:[~2019-06-25 5:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 9:13 [PATCH 1/8 v2] MIPS: ralink: mt7628a.dtsi: Add SPDX GPL-2.0 license identifier Stefan Roese
2019-05-27 9:13 ` [PATCH 2/8 v2] MIPS: ralink: mt7628a.dtsi: Add pinmux DT node Stefan Roese
2019-06-24 21:16 ` Paul Burton
2019-05-27 9:13 ` [PATCH 3/8 v2] MIPS: ralink: mt7628a.dtsi: Add pinctrl DT properties to the UART nodes Stefan Roese
2019-06-24 21:16 ` Paul Burton
2019-05-27 9:13 ` [PATCH 4/8 v2] MIPS: ralink: mt7628a.dtsi: Add GPIO controller DT node Stefan Roese
2019-06-24 21:16 ` Paul Burton
2019-05-27 9:13 ` [PATCH 5/8 v2] MIPS: ralink: mt7628a.dtsi: Add I2C " Stefan Roese
2019-05-28 20:41 ` Paul Burton
2019-05-29 5:19 ` Stefan Roese
2019-06-24 21:24 ` Paul Burton
2019-06-24 22:07 ` Wolfram Sang
2019-06-29 9:07 ` Stefan Roese
2019-05-27 9:13 ` [PATCH 6/8 v2] MIPS: ralink: mt7628a.dtsi: Add SPI " Stefan Roese
2019-05-28 20:43 ` Paul Burton
2019-05-29 5:22 ` Stefan Roese
2019-06-24 21:16 ` Paul Burton
2019-05-27 9:13 ` [PATCH 7/8 v2] MIPS: ralink: mt7628a.dtsi: Add watchdog " Stefan Roese
2019-06-24 21:16 ` Paul Burton
2019-05-27 9:13 ` [PATCH 8/8 v2] MIPS: ralink: Add GARDENA smart Gateway MT7688 board Stefan Roese
2019-06-24 21:30 ` Paul Burton
2019-06-25 5:31 ` Stefan Roese [this message]
2019-06-24 21:16 ` [PATCH 1/8 v2] MIPS: ralink: mt7628a.dtsi: Add SPDX GPL-2.0 license identifier Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c102edbb-c322-28e7-0b98-54e446ce1872@denx.de \
--to=sr@denx.de \
--cc=harveyhuntnexus@gmail.com \
--cc=john@phrozen.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).