[PATCH 0/2] Remove orphan declarations and comments

[PATCH 0/2] Remove orphan declarations and comments

[Gaosheng Cui]

This series contains a few cleanup patches, to remove unused
declarations which have been removed and some useless comments. Thanks!

Gaosheng Cui (2):
  MIPS: remove orphan sb1250_time_init() declaration
  MIPS: IRQ: remove orphan allocate_irqno() declaration

 arch/mips/include/asm/irq.h           | 1 -
 arch/mips/include/asm/sibyte/sb1250.h | 1 -
 arch/mips/sibyte/sb1250/irq.c         | 6 ------
 3 files changed, 8 deletions(-)

-- 
2.25.1

[PATCH 1/2] MIPS: remove orphan sb1250_time_init() declaration

[Gaosheng Cui]

All uses of sb1250_time_init() have been removed by
commit d527eef5b7f1 ("[MIPS] Sibyte: Finish conversion to modern
time APIs."), so remove the orphan declaration.

The comments about sb1250_time_init() is useless in arch_init_irq(),
so remove these comments.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 arch/mips/include/asm/sibyte/sb1250.h | 1 -
 arch/mips/sibyte/sb1250/irq.c         | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/arch/mips/include/asm/sibyte/sb1250.h b/arch/mips/include/asm/sibyte/sb1250.h
index dbde5f93f0dd..495b31925ed7 100644
--- a/arch/mips/include/asm/sibyte/sb1250.h
+++ b/arch/mips/include/asm/sibyte/sb1250.h
@@ -32,7 +32,6 @@ extern unsigned int soc_type;
 extern unsigned int periph_rev;
 extern unsigned int zbbus_mhz;
 
-extern void sb1250_time_init(void);
 extern void sb1250_mask_irq(int cpu, int irq);
 extern void sb1250_unmask_irq(int cpu, int irq);
 
diff --git a/arch/mips/sibyte/sb1250/irq.c b/arch/mips/sibyte/sb1250/irq.c
index 86f49c48fc34..2f08ad267a11 100644
--- a/arch/mips/sibyte/sb1250/irq.c
+++ b/arch/mips/sibyte/sb1250/irq.c
@@ -262,12 +262,6 @@ void __init arch_init_irq(void)
 	__raw_writeq(tmp, IOADDR(A_IMR_REGISTER(0, R_IMR_INTERRUPT_MASK)));
 	__raw_writeq(tmp, IOADDR(A_IMR_REGISTER(1, R_IMR_INTERRUPT_MASK)));
 
-	/*
-	 * Note that the timer interrupts are also mapped, but this is
-	 * done in sb1250_time_init().	Also, the profiling driver
-	 * does its own management of IP7.
-	 */
-
 	/* Enable necessary IPs, disable the rest */
 	change_c0_status(ST0_IM, imask);
 }
-- 
2.25.1

[PATCH 2/2] MIPS: IRQ: remove orphan allocate_irqno() declaration

[Gaosheng Cui]

All uses of allocate_irqno() have been removed by
commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"),
so remove the orphan declaration.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 arch/mips/include/asm/irq.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index 57561e0e6e8d..2f47f56fca82 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq);
 extern void arch_init_irq(void);
 extern void spurious_interrupt(void);
 
-extern int allocate_irqno(void);
 extern void alloc_legacy_irqno(void);
 extern void free_irqno(unsigned int irq);
 
-- 
2.25.1

Re: [PATCH 0/2] Remove orphan declarations and comments

[Philippe Mathieu-Daudé]

On Tue, Sep 20, 2022 at 3:11 PM Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
>
> This series contains a few cleanup patches, to remove unused
> declarations which have been removed and some useless comments. Thanks!
>
> Gaosheng Cui (2):
>   MIPS: remove orphan sb1250_time_init() declaration
>   MIPS: IRQ: remove orphan allocate_irqno() declaration

Series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH 1/2] MIPS: remove orphan sb1250_time_init() declaration

[Thomas Bogendoerfer]

On Tue, Sep 20, 2022 at 09:07:10PM +0800, Gaosheng Cui wrote:
> All uses of sb1250_time_init() have been removed by
> commit d527eef5b7f1 ("[MIPS] Sibyte: Finish conversion to modern
> time APIs."), so remove the orphan declaration.
> 
> The comments about sb1250_time_init() is useless in arch_init_irq(),
> so remove these comments.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  arch/mips/include/asm/sibyte/sb1250.h | 1 -
>  arch/mips/sibyte/sb1250/irq.c         | 6 ------
>  2 files changed, 7 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 2/2] MIPS: IRQ: remove orphan allocate_irqno() declaration

[Thomas Bogendoerfer]

On Tue, Sep 20, 2022 at 09:07:11PM +0800, Gaosheng Cui wrote:
> All uses of allocate_irqno() have been removed by
> commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"),
> so remove the orphan declaration.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  arch/mips/include/asm/irq.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
> index 57561e0e6e8d..2f47f56fca82 100644
> --- a/arch/mips/include/asm/irq.h
> +++ b/arch/mips/include/asm/irq.h
> @@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq);
>  extern void arch_init_irq(void);
>  extern void spurious_interrupt(void);
>  
> -extern int allocate_irqno(void);
>  extern void alloc_legacy_irqno(void);
>  extern void free_irqno(unsigned int irq);
>  
> -- 
> 2.25.1

applied to mips-next. The patch didn't apply, because you alread removed
alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that
while applying, but please you latest mips-next branch for creating
patches next time.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 2/2] MIPS: IRQ: remove orphan allocate_irqno() declaration

[cuigaosheng]

> applied to mips-next. The patch didn't apply, because you alread removed
> alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that
> while applying, but please you latest mips-next branch for creating
> patches next time.

Thanks for taking the time to review this patch, I checked my patches,you are
right, it is my negligence,Thanks again for reminding me!

On 2022/9/24 17:45, Thomas Bogendoerfer wrote:
> On Tue, Sep 20, 2022 at 09:07:11PM +0800, Gaosheng Cui wrote:
>> All uses of allocate_irqno() have been removed by
>> commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"),
>> so remove the orphan declaration.
>>
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>> ---
>>   arch/mips/include/asm/irq.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
>> index 57561e0e6e8d..2f47f56fca82 100644
>> --- a/arch/mips/include/asm/irq.h
>> +++ b/arch/mips/include/asm/irq.h
>> @@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq);
>>   extern void arch_init_irq(void);
>>   extern void spurious_interrupt(void);
>>   
>> -extern int allocate_irqno(void);
>>   extern void alloc_legacy_irqno(void);
>>   extern void free_irqno(unsigned int irq);
>>   
>> -- 
>> 2.25.1
> applied to mips-next. The patch didn't apply, because you alread removed
> alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that
> while applying, but please you latest mips-next branch for creating
> patches next time.
>
> Thomas.
>