linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-mips@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"BCM Kernel Feedback" <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
Date: Tue, 17 Mar 2020 15:23:20 +0530	[thread overview]
Message-ID: <CAHO=5PEiPK=uF_rEJ+ujaP=oq2fPR1VHvczjZ1JQAqDdjTsMHQ@mail.gmail.com> (raw)
In-Reply-To: <e94bbb2c-6f36-61bb-d26a-2ce3e1a139e0@cogentembedded.com>

On Tue, Mar 17, 2020 at 2:39 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
>
> > Remove unused variable initialization.
>
>     I think it's not an initialization, it's an assignment. :-)
Thanks  will fix it and send v2.
>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> >   drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e8..6fd62657e35f 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> >       prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
> >
> >       while (rbytes)  {
> > -             nbytes = rbytes;
> > -
> >               nbytes = min_t(u32, rbytes, param[0].u.memref.size);
> >
> >               /* Fill additional invoke cmd params */
>
> MBR, Sergei

      reply	other threads:[~2020-03-17  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17  4:07 [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init Rayagonda Kokatanur
2020-03-17  9:09 ` Sergei Shtylyov
2020-03-17  9:53   ` Rayagonda Kokatanur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHO=5PEiPK=uF_rEJ+ujaP=oq2fPR1VHvczjZ1JQAqDdjTsMHQ@mail.gmail.com' \
    --to=rayagonda.kokatanur@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).