* [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
@ 2020-03-17 4:07 Rayagonda Kokatanur
2020-03-17 9:09 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-17 4:07 UTC (permalink / raw)
To: Rafał Miłecki, linux-mips, linux-kernel, BCM Kernel Feedback
Cc: Rayagonda Kokatanur
Remove unused variable initialization.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index ed10da5313e8..6fd62657e35f 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
while (rbytes) {
- nbytes = rbytes;
-
nbytes = min_t(u32, rbytes, param[0].u.memref.size);
/* Fill additional invoke cmd params */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
2020-03-17 4:07 [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init Rayagonda Kokatanur
@ 2020-03-17 9:09 ` Sergei Shtylyov
2020-03-17 9:53 ` Rayagonda Kokatanur
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2020-03-17 9:09 UTC (permalink / raw)
To: Rayagonda Kokatanur, Rafał Miłecki, linux-mips,
linux-kernel, BCM Kernel Feedback
Hello!
On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
> Remove unused variable initialization.
I think it's not an initialization, it's an assignment. :-)
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>
> while (rbytes) {
> - nbytes = rbytes;
> -
> nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>
> /* Fill additional invoke cmd params */
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init
2020-03-17 9:09 ` Sergei Shtylyov
@ 2020-03-17 9:53 ` Rayagonda Kokatanur
0 siblings, 0 replies; 3+ messages in thread
From: Rayagonda Kokatanur @ 2020-03-17 9:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rafał Miłecki, linux-mips, Linux Kernel Mailing List,
BCM Kernel Feedback
On Tue, Mar 17, 2020 at 2:39 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
>
> > Remove unused variable initialization.
>
> I think it's not an initialization, it's an assignment. :-)
Thanks will fix it and send v2.
>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> > drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e8..6fd62657e35f 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> > prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
> >
> > while (rbytes) {
> > - nbytes = rbytes;
> > -
> > nbytes = min_t(u32, rbytes, param[0].u.memref.size);
> >
> > /* Fill additional invoke cmd params */
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-17 9:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 4:07 [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init Rayagonda Kokatanur
2020-03-17 9:09 ` Sergei Shtylyov
2020-03-17 9:53 ` Rayagonda Kokatanur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).