From: Russell King <rmk+kernel@armlinux.org.uk>
To: linux-mips@linux-mips.org, linux-nfs@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
target-devel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes
Date: Tue, 31 Jan 2017 19:19:29 +0000 [thread overview]
Message-ID: <E1cYdxh-0000XJ-RN@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20170131191704.GA8281@n2100.armlinux.org.uk>
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an
unnecessary dependency for quite a large amount of the kernel. There's
very little which actually requires definitions from phy.h in net/dsa.h
- the include itself only wants the declaration of a couple of
structures and IFNAMSIZ.
Add linux/if.h for IFNAMSIZ, declarations for the structures, phy.h to
mv88e6xxx.h as it needs it for phy_interface_t, and remove both phy.h
and phy_fixed.h from net/dsa.h.
This patch reduces from around 800 files rebuilt to around 40 - even
with ccache, the time difference is noticable.
Tested-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
include/net/dsa.h | 6 ++++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
index af54baea47cf..3a949095068a 100644
--- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
+++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
@@ -15,6 +15,7 @@
#include <linux/if_vlan.h>
#include <linux/irq.h>
#include <linux/gpio/consumer.h>
+#include <linux/phy.h>
#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
diff --git a/include/net/dsa.h b/include/net/dsa.h
index b122196d5a1f..887b2f98f9ea 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -11,15 +11,17 @@
#ifndef __LINUX_NET_DSA_H
#define __LINUX_NET_DSA_H
+#include <linux/if.h>
#include <linux/if_ether.h>
#include <linux/list.h>
#include <linux/timer.h>
#include <linux/workqueue.h>
#include <linux/of.h>
-#include <linux/phy.h>
-#include <linux/phy_fixed.h>
#include <linux/ethtool.h>
+struct phy_device;
+struct fixed_phy_status;
+
enum dsa_tag_protocol {
DSA_TAG_PROTO_NONE = 0,
DSA_TAG_PROTO_DSA,
--
2.7.4
next prev parent reply other threads:[~2017-01-31 19:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170118001403.GJ27312@n2100.armlinux.org.uk>
2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
2017-01-31 19:18 ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-01-31 19:48 ` Anna Schumaker
2017-01-31 19:18 ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
2017-01-31 19:18 ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
2017-02-01 9:40 ` Nicolas Ferre
2017-02-01 9:40 ` Nicolas Ferre
2017-01-31 19:18 ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
2017-01-31 19:18 ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
2017-02-01 9:55 ` Rafał Miłecki
2017-01-31 19:18 ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
2017-01-31 19:18 ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
2017-02-01 10:27 ` Thomas Petazzoni
2017-01-31 19:19 ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
2017-01-31 20:15 ` Timur Tabi
2017-01-31 19:19 ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
2017-01-31 19:32 ` Bart Van Assche
2017-01-31 19:32 ` Bart Van Assche
2017-01-31 19:19 ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
2017-01-31 19:19 ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-02-01 19:07 ` Felix Manlunas
2017-02-01 19:07 ` Felix Manlunas
2017-01-31 19:19 ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
2017-02-01 5:34 ` Kalle Valo
2017-01-31 19:19 ` Russell King [this message]
2017-02-01 2:42 ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1cYdxh-0000XJ-RN@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).