* [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
@ 2019-01-21 2:48 Masahiro Yamada
2019-01-21 17:41 ` Paul Burton
2019-01-23 17:51 ` Paul Burton
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-21 2:48 UTC (permalink / raw)
To: Paul Burton, linux-mips
Cc: Masahiro Yamada, Ralf Baechle, James Hogan, linux-kernel
This line is weird in multiple ways.
(CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
to 'y' because scripts/Makefile.asm-generic does not include
include/config/auto.conf. So, the asm-generic wrapper of checksum.h
is never generated.
Even if you manage to generate it, it is never included by anyone
because MIPS has the checkin header with the same file name:
arch/mips/include/asm/checksum.h
As you see in the top Makefile, the checkin headers are included before
generated ones.
LINUXINCLUDE := \
-I$(srctree)/arch/$(SRCARCH)/include \
-I$(objtree)/arch/$(SRCARCH)/include/generated \
...
Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
already added the asm-generic fallback code in the checkin header:
#ifdef CONFIG_GENERIC_CSUM
#include <asm/generic/checksum.h>
#else
...
#endif
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/mips/include/asm/Kbuild | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index f15d5db..87b86cd 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -3,7 +3,6 @@ generated-y += syscall_table_32_o32.h
generated-y += syscall_table_64_n32.h
generated-y += syscall_table_64_n64.h
generated-y += syscall_table_64_o32.h
-generic-(CONFIG_GENERIC_CSUM) += checksum.h
generic-y += current.h
generic-y += device.h
generic-y += dma-contiguous.h
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
2019-01-21 2:48 [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h Masahiro Yamada
@ 2019-01-21 17:41 ` Paul Burton
2019-01-22 2:01 ` Masahiro Yamada
2019-01-23 17:51 ` Paul Burton
1 sibling, 1 reply; 4+ messages in thread
From: Paul Burton @ 2019-01-21 17:41 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-mips, Ralf Baechle, James Hogan, linux-kernel
Hi Masahiro,
On Mon, Jan 21, 2019 at 11:48:49AM +0900, Masahiro Yamada wrote:
> This line is weird in multiple ways.
>
> (CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
>
> Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
> to 'y' because scripts/Makefile.asm-generic does not include
> include/config/auto.conf. So, the asm-generic wrapper of checksum.h
> is never generated.
>
> Even if you manage to generate it, it is never included by anyone
> because MIPS has the checkin header with the same file name:
>
> arch/mips/include/asm/checksum.h
>
> As you see in the top Makefile, the checkin headers are included before
> generated ones.
>
> LINUXINCLUDE := \
> -I$(srctree)/arch/$(SRCARCH)/include \
> -I$(objtree)/arch/$(SRCARCH)/include/generated \
> ...
>
> Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
> already added the asm-generic fallback code in the checkin header:
>
> #ifdef CONFIG_GENERIC_CSUM
> #include <asm/generic/checksum.h>
> #else
> ...
> #endif
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Good catch. Would you prefer to take this through your kbuild tree or
that I take it through the MIPS tree?
If the former:
Acked-by: Paul Burton <paul.burton@mips.com>
Thanks,
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
2019-01-21 17:41 ` Paul Burton
@ 2019-01-22 2:01 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-22 2:01 UTC (permalink / raw)
To: Paul Burton; +Cc: linux-mips, Ralf Baechle, James Hogan, linux-kernel
Hi Paul,
On Tue, Jan 22, 2019 at 2:44 AM Paul Burton <paul.burton@mips.com> wrote:
>
> Hi Masahiro,
>
> On Mon, Jan 21, 2019 at 11:48:49AM +0900, Masahiro Yamada wrote:
> > This line is weird in multiple ways.
> >
> > (CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
> >
> > Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
> > to 'y' because scripts/Makefile.asm-generic does not include
> > include/config/auto.conf. So, the asm-generic wrapper of checksum.h
> > is never generated.
> >
> > Even if you manage to generate it, it is never included by anyone
> > because MIPS has the checkin header with the same file name:
> >
> > arch/mips/include/asm/checksum.h
> >
> > As you see in the top Makefile, the checkin headers are included before
> > generated ones.
> >
> > LINUXINCLUDE := \
> > -I$(srctree)/arch/$(SRCARCH)/include \
> > -I$(objtree)/arch/$(SRCARCH)/include/generated \
> > ...
> >
> > Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
> > already added the asm-generic fallback code in the checkin header:
> >
> > #ifdef CONFIG_GENERIC_CSUM
> > #include <asm/generic/checksum.h>
> > #else
> > ...
> > #endif
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Good catch. Would you prefer to take this through your kbuild tree or
> that I take it through the MIPS tree?
Could you apply it to MIPS tree? Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
2019-01-21 2:48 [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h Masahiro Yamada
2019-01-21 17:41 ` Paul Burton
@ 2019-01-23 17:51 ` Paul Burton
1 sibling, 0 replies; 4+ messages in thread
From: Paul Burton @ 2019-01-23 17:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Paul Burton, linux-mips, Masahiro Yamada, Ralf Baechle,
James Hogan, linux-kernel, linux-mips
Hello,
Masahiro Yamada wrote:
> This line is weird in multiple ways.
>
> (CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).
>
> Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
> to 'y' because scripts/Makefile.asm-generic does not include
> include/config/auto.conf. So, the asm-generic wrapper of checksum.h
> is never generated.
>
> Even if you manage to generate it, it is never included by anyone
> because MIPS has the checkin header with the same file name:
>
> arch/mips/include/asm/checksum.h
>
> As you see in the top Makefile, the checkin headers are included before
> generated ones.
>
> LINUXINCLUDE := -I$(srctree)/arch/$(SRCARCH)/include -I$(objtree)/arch/$(SRCARCH)/include/generated ...
>
> Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
> already added the asm-generic fallback code in the checkin header:
>
> #ifdef CONFIG_GENERIC_CSUM
> #include <asm/generic/checksum.h>
> #else
> ...
> #endif
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to mips-next.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-23 17:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 2:48 [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h Masahiro Yamada
2019-01-21 17:41 ` Paul Burton
2019-01-22 2:01 ` Masahiro Yamada
2019-01-23 17:51 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).