* Re: [PATCH] MIPS: BCM63XX: drop unused and broken DSP platform device
[not found] <20181230115509.6542-1-jonas.gorski@gmail.com>
@ 2018-12-31 15:14 ` Paul Burton
0 siblings, 0 replies; only message in thread
From: Paul Burton @ 2018-12-31 15:14 UTC (permalink / raw)
To: Jonas Gorski
Cc: linux-mips, Ralf Baechle, Paul Burton, James Hogan,
Florian Fainelli, linux-mips
Hello,
Jonas Gorski wrote:
> Trying to register the DSP platform device results in a null pointer
> access:
>
> [ 0.124184] CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 804e305c, ra == 804e6f20
> [ 0.135208] Oops[#1]:
> [ 0.137514] CPU: 0 PID: 1 Comm: swapper Not tainted 4.14.87
> ...
> [ 0.197117] epc : 804e305c bcm63xx_dsp_register+0x80/0xa4
> [ 0.202838] ra : 804e6f20 board_register_devices+0x258/0x390
> ...
>
> This happens because it tries to copy the passed platform data over the
> platform_device's unpopulated platform_data.
>
> Since this code has been broken since its submission, no driver was ever
> submitted for it, and apparently nobody was using it, just remove it
> instead of trying to fix it.
>
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] only message in thread