* [PATCH] MIPS: ath79: fix ar933x uart parity mode
@ 2019-06-17 13:43 Stefan Hellermann
2019-06-19 20:40 ` Paul Burton
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hellermann @ 2019-06-17 13:43 UTC (permalink / raw)
To: linux-mips
While trying to get the uart with parity working I found setting even
parity enabled odd parity insted. Fix the register settings to match
the datasheet of AR9331.
A similar patch was created by 8devices, but not sent upstream.
https://github.com/8devices/openwrt-8devices/commit/77c5586ade3bb72cda010afad3f209ed0c98ea7c
Signed-off-by: Stefan Hellermann <stefan@the2masters.de>
---
arch/mips/include/asm/mach-ath79/ar933x_uart.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/include/asm/mach-ath79/ar933x_uart.h b/arch/mips/include/asm/mach-ath79/ar933x_uart.h
index c2917b39966b..bba2c8837951 100644
--- a/arch/mips/include/asm/mach-ath79/ar933x_uart.h
+++ b/arch/mips/include/asm/mach-ath79/ar933x_uart.h
@@ -27,8 +27,8 @@
#define AR933X_UART_CS_PARITY_S 0
#define AR933X_UART_CS_PARITY_M 0x3
#define AR933X_UART_CS_PARITY_NONE 0
-#define AR933X_UART_CS_PARITY_ODD 1
-#define AR933X_UART_CS_PARITY_EVEN 2
+#define AR933X_UART_CS_PARITY_ODD 2
+#define AR933X_UART_CS_PARITY_EVEN 3
#define AR933X_UART_CS_IF_MODE_S 2
#define AR933X_UART_CS_IF_MODE_M 0x3
#define AR933X_UART_CS_IF_MODE_NONE 0
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: ath79: fix ar933x uart parity mode
2019-06-17 13:43 [PATCH] MIPS: ath79: fix ar933x uart parity mode Stefan Hellermann
@ 2019-06-19 20:40 ` Paul Burton
0 siblings, 0 replies; 2+ messages in thread
From: Paul Burton @ 2019-06-19 20:40 UTC (permalink / raw)
To: Stefan Hellermann; +Cc: linux-mips, linux-mips
Hello,
Stefan Hellermann wrote:
> While trying to get the uart with parity working I found setting even
> parity enabled odd parity insted. Fix the register settings to match
> the datasheet of AR9331.
>
> A similar patch was created by 8devices, but not sent upstream.
> https://github.com/8devices/openwrt-8devices/commit/77c5586ade3bb72cda010afad3f209ed0c98ea7c
>
> Signed-off-by: Stefan Hellermann <stefan@the2masters.de>
Applied to mips-fixes.
Thanks,
Paul
[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@mips.com to report it. ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 13:43 [PATCH] MIPS: ath79: fix ar933x uart parity mode Stefan Hellermann
2019-06-19 20:40 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).