* [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'
@ 2022-09-30 6:38 Dong Chenchen
2022-10-04 14:53 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 2+ messages in thread
From: Dong Chenchen @ 2022-09-30 6:38 UTC (permalink / raw)
To: airlied, daniel
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, Xinhui.Pan,
alexander.deucher, Jerry.Zuo, yuehaibing, linux-mips, amd-gfx,
dri-devel, linux-kernel, kernel test robot, Dong Chenchen
Kernel test robot throws below warning ->
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:
In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets':
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:439:14:
warning: variable 'sdp_stream_enable' set but not used
[-Wunused-but-set-variable]
439 | bool sdp_stream_enable = false;
Removed unused variable 'sdp_stream_enable'.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dong Chenchen <dongchenchen2@huawei.com>
---
.../dc/dcn31/dcn31_hpo_dp_stream_encoder.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
index 23621ff08c90..7daafbab98da 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
@@ -436,32 +436,28 @@ static void dcn31_hpo_dp_stream_enc_update_dp_info_packets(
{
struct dcn31_hpo_dp_stream_encoder *enc3 = DCN3_1_HPO_DP_STREAM_ENC_FROM_HPO_STREAM_ENC(enc);
uint32_t dmdata_packet_enabled = 0;
- bool sdp_stream_enable = false;
- if (info_frame->vsc.valid) {
+ if (info_frame->vsc.valid)
enc->vpg->funcs->update_generic_info_packet(
enc->vpg,
0, /* packetIndex */
&info_frame->vsc,
true);
- sdp_stream_enable = true;
- }
- if (info_frame->spd.valid) {
+
+ if (info_frame->spd.valid)
enc->vpg->funcs->update_generic_info_packet(
enc->vpg,
2, /* packetIndex */
&info_frame->spd,
true);
- sdp_stream_enable = true;
- }
- if (info_frame->hdrsmd.valid) {
+
+ if (info_frame->hdrsmd.valid)
enc->vpg->funcs->update_generic_info_packet(
enc->vpg,
3, /* packetIndex */
&info_frame->hdrsmd,
true);
- sdp_stream_enable = true;
- }
+
/* enable/disable transmission of packet(s).
* If enabled, packet transmission begins on the next frame
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'
2022-09-30 6:38 [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable' Dong Chenchen
@ 2022-10-04 14:53 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-10-04 14:53 UTC (permalink / raw)
To: Dong Chenchen, airlied, daniel
Cc: harry.wentland, sunpeng.li, Xinhui.Pan, alexander.deucher,
Jerry.Zuo, yuehaibing, linux-mips, amd-gfx, dri-devel,
linux-kernel, kernel test robot
On 2022-09-30 02:38, Dong Chenchen wrote:
> Kernel test robot throws below warning ->
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:
> In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:439:14:
> warning: variable 'sdp_stream_enable' set but not used
> [-Wunused-but-set-variable]
> 439 | bool sdp_stream_enable = false;
>
> Removed unused variable 'sdp_stream_enable'.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dong Chenchen <dongchenchen2@huawei.com>
> ---
> .../dc/dcn31/dcn31_hpo_dp_stream_encoder.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> index 23621ff08c90..7daafbab98da 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> @@ -436,32 +436,28 @@ static void dcn31_hpo_dp_stream_enc_update_dp_info_packets(
> {
> struct dcn31_hpo_dp_stream_encoder *enc3 = DCN3_1_HPO_DP_STREAM_ENC_FROM_HPO_STREAM_ENC(enc);
> uint32_t dmdata_packet_enabled = 0;
> - bool sdp_stream_enable = false;
>
> - if (info_frame->vsc.valid) {
> + if (info_frame->vsc.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 0, /* packetIndex */
> &info_frame->vsc,
> true);
> - sdp_stream_enable = true;
> - }
> - if (info_frame->spd.valid) {
> +
> + if (info_frame->spd.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 2, /* packetIndex */
> &info_frame->spd,
> true);
> - sdp_stream_enable = true;
> - }
> - if (info_frame->hdrsmd.valid) {
> +
> + if (info_frame->hdrsmd.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 3, /* packetIndex */
> &info_frame->hdrsmd,
> true);
> - sdp_stream_enable = true;
> - }
> +
> /* enable/disable transmission of packet(s).
> * If enabled, packet transmission begins on the next frame
> */
Thanks a lot for your patch,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-04 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 6:38 [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable' Dong Chenchen
2022-10-04 14:53 ` Rodrigo Siqueira Jordao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).