linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Joshua Kinard <kumba@gentoo.org>
Cc: James Hogan <james.hogan@imgtec.com>, <linux-mips@linux-mips.org>
Subject: Re: gcc-6.3.x miscompiling code for IP27?
Date: Thu, 26 Jan 2017 16:17:34 +0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1701261612230.13564@tp.orcam.me.uk> (raw)
In-Reply-To: <addded89-4410-f818-9eb8-c1428f561795@gentoo.org>

On Wed, 25 Jan 2017, Joshua Kinard wrote:

> Instead of making -fno-stack-check IP27-only, I can do a patch for the main
> arch/mips/Makefile instead to turn it off globally.  It looks like this option
> has been available in gcc as far back as at least 3.0.4, so would any kind of
> compatibility/version check for gcc be needed?  I'm not sure what the oldest
> gcc supported by the MIPS code currently is.

 Wrapping a compiler option into `$(call cc-option,...)' is always safe to 
do if unsure.  In this case however Documentation/Changes states 3.2 as 
the minimum GCC version so it looks to me like no such check is required.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Joshua Kinard <kumba@gentoo.org>
Cc: James Hogan <james.hogan@imgtec.com>, linux-mips@linux-mips.org
Subject: Re: gcc-6.3.x miscompiling code for IP27?
Date: Thu, 26 Jan 2017 16:17:34 +0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1701261612230.13564@tp.orcam.me.uk> (raw)
Message-ID: <20170126161734.CDhJARzqGbaDS9xlNZLwJdBGerNX6euqznMmSnxvcr8@z> (raw)
In-Reply-To: <addded89-4410-f818-9eb8-c1428f561795@gentoo.org>

On Wed, 25 Jan 2017, Joshua Kinard wrote:

> Instead of making -fno-stack-check IP27-only, I can do a patch for the main
> arch/mips/Makefile instead to turn it off globally.  It looks like this option
> has been available in gcc as far back as at least 3.0.4, so would any kind of
> compatibility/version check for gcc be needed?  I'm not sure what the oldest
> gcc supported by the MIPS code currently is.

 Wrapping a compiler option into `$(call cc-option,...)' is always safe to 
do if unsure.  In this case however Documentation/Changes states 3.2 as 
the minimum GCC version so it looks to me like no such check is required.

  Maciej

  reply	other threads:[~2017-01-26 16:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22 23:28 gcc-6.3.x miscompiling code for IP27? Joshua Kinard
2017-01-23  1:03 ` Joshua Kinard
2017-01-23  2:24   ` Joshua Kinard
2017-01-23 18:00     ` Joshua Kinard
2017-01-24 15:45       ` James Hogan
2017-01-24 15:45         ` James Hogan
2017-01-25 19:15         ` Joshua Kinard
2017-01-26 16:17           ` Maciej W. Rozycki [this message]
2017-01-26 16:17             ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1701261612230.13564@tp.orcam.me.uk \
    --to=macro@imgtec.com \
    --cc=james.hogan@imgtec.com \
    --cc=kumba@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).