From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Paul Burton <paulburton@kernel.org>
Cc: "Victor Kamensky (kamensky)" <kamensky@cisco.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
"bruce.ashfield@gmail.com" <bruce.ashfield@gmail.com>,
"richard.purdie@linuxfoundation.org"
<richard.purdie@linuxfoundation.org>
Subject: Re: [PATCH 1/2] mips: vdso: fix 'jalr t9' crash in vdso code
Date: Mon, 17 Feb 2020 13:38:55 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2002171333100.2579827@eddie.linux-mips.org> (raw)
In-Reply-To: <20200211170110.ewrndsh7zzx7ocqi@lantea.localdomain>
On Tue, 11 Feb 2020, Paul Burton wrote:
> > I believe my second patch: build time check for 'jalr t9' in code
> > should still be useful, since it verifies that conversion to 'bal' driven
> > by -mrelax-pic-calls does happen.
> >
> > Please let me know if you have any additional feedback before
> > I post v2 set of patches.
>
> That sounds great, and nothing else springs to mind. I'll look out for
> v2.
BTW, while at it you might want to verify that the microMIPS variant does
the right thing. As I recall there was an issue with the R_MICROMIPS_JALR
reloc that I meant to fix, but didn't get to before I left MIPS.
Maciej
next prev parent reply other threads:[~2020-02-17 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 23:31 [PATCH 0/2] mips: vdso: fix 'jalr t9' crash in vdso code Victor Kamensky
2020-02-03 23:31 ` [PATCH 1/2] " Victor Kamensky
2020-02-10 19:14 ` Paul Burton
2020-02-10 19:33 ` Paul Burton
2020-02-10 21:12 ` Victor Kamensky (kamensky)
2020-02-10 22:52 ` Paul Burton
2020-02-10 23:11 ` Paul Burton
2020-02-11 16:55 ` Victor Kamensky (kamensky)
2020-02-11 17:01 ` Paul Burton
2020-02-17 13:38 ` Maciej W. Rozycki [this message]
2020-02-03 23:31 ` [PATCH 2/2] mips: vdso: add build time check that no 'jalr t9' calls left Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2002171333100.2579827@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=bruce.ashfield@gmail.com \
--cc=jhogan@kernel.org \
--cc=kamensky@cisco.com \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).