From: Yinbo Zhu <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
zhuyinbo@loongson.cn, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Juxin Gao <gaojuxin@loongson.cn>, Bibo Mao <maobibo@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, richard.liu@st.com,
Arnaud Patard <apatard@mandriva.com>,
Hongbing Hu <huhb@lemote.com>,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
Date: Mon, 14 Nov 2022 17:50:22 +0800 [thread overview]
Message-ID: <d5457109-3bcb-e7d3-067d-9e4acd66ac17@loongson.cn> (raw)
In-Reply-To: <d9edb6e1-c3da-0f5b-546d-37d8151aaa35@linaro.org>
在 2022/11/8 下午11:28, Krzysztof Kozlowski 写道:
> On 08/11/2022 10:21, Yinbo Zhu wrote:
>> Add the Loongson series gpio binding with DT schema format using
>> json-schema.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>> ---
>> .../bindings/gpio/loongson,ls-gpio.yaml | 154 ++++++++++++++++++
>> MAINTAINERS | 11 ++
>> 2 files changed, 165 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> new file mode 100644
>> index 000000000000..9d335262ddcc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> @@ -0,0 +1,154 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpio/loongson,ls-gpio.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Loongson series GPIO controller.
>> +
>> +maintainers:
>> + - Yinbo Zhu <zhuyinbo@loongson.cn>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - loongson,ls2k-gpio
>> + - loongson,ls7a-gpio
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + ngpios: true
>
> minimum? maximum?
okay, I got it.
>
>> +
>> + "#gpio-cells":
>> + const: 2
>> +
>> + gpio-controller: true
>> +
>> + gpio-ranges: true
>> +
>> + loongson,conf_offset:
>
> No underscores in node names. Plus comments from Linus seem to apply
> here as well. Drop it entirely or explain why this is not part of
> compatible, why this is needed and why encoding programming model
> address in DT matches the DT...
Add it is to distinguish differnt address in different platform.
and I had drop them and initial them in kernel driver that depend
on diffent compatible.
>
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO configuration offset address.
>> +
>> + loongson,out_offset:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO output value offset address.
>
> Drop
>
>> +
>> + loongson,in_offset:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate this GPIO input value offset address.
>
> Drop
>
>
>> +
>> + loongson,gpio_base:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + This option indicate the first GPIO number in this node.
>
> Drop
>
>
>> +
>> + loongson,support_irq:
>> + $ref: /schemas/types.yaml#/definitions/flag
>> + description:
>> + This option indicate this GPIO whether support interrupt.
>
> Drop
>
>> +
>> + interrupts:
>> + minItems: 1
>> + maxItems: 64
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - ngpios
>> + - "#gpio-cells"
>> + - gpio-controller
>> + - gpio-ranges
>> + - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + gpio0: gpio@1fe00500 {
>> + compatible = "loongson,ls2k-gpio";
>> + reg = <0x1fe00500 0x38>;
>> + ngpios = <64>;
>> + #gpio-cells = <2>;
>> + gpio-controller;
>> + gpio-ranges = <&pctrl 0 0 15>,
>> + <&pctrl 16 16 15>,
>> + <&pctrl 32 32 10>,
>> + <&pctrl 44 44 20>;
>> + loongson,conf_offset = <0>;
>> + loongson,out_offset = <0x10>;
>> + loongson,in_offset = <0x20>;
>> + loongson,gpio_base = <0>;
>> + loongson,support_irq;
>> + interrupt-parent = <&liointc1>;
>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>,
>> + <29 IRQ_TYPE_LEVEL_LOW>,
>> + <30 IRQ_TYPE_LEVEL_LOW>,
>> + <30 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <26 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>
> What's this?
There was no interrupt function in this gpio.
>
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <>,
>> + <>,
>
> What's this?
>
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>,
>> + <27 IRQ_TYPE_LEVEL_LOW>;
>> + };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 916b2d9cffc0..878b8320ac3b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -12048,6 +12048,17 @@ S: Maintained
>> F: Documentation/devicetree/bindings/hwinfo/loongson,ls2k-chipid.yaml
>> F: drivers/soc/loongson/loongson2_guts.c
>>
>> +LOONGSON SERIES GPIO DRIVER
>> +M: Richard Liu, STMicroelectronics <richard.liu@st.com>
>> +M: Arnaud Patard <apatard@mandriva.com>
>> +M: Hongbing Hu <huhb@lemote.com>
>> +M: Huacai Chen <chenhuacai@kernel.org>
>> +M: Yinbo Zhu <zhuyinbo@loongson.cn>
>
> Are they all maintainers of this driver?
add huacai and myself as maintainer.
>
>> +L: linux-gpio@vger.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> +F: drivers/gpio/gpio-loongson.c
>> +
>> LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
>> M: Sathya Prakash <sathya.prakash@broadcom.com>
>> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-11-14 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:21 [PATCH v1 1/2] gpio: loongson: add dts/acpi gpio support Yinbo Zhu
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
2022-11-08 12:11 ` Linus Walleij
2022-11-08 15:28 ` Krzysztof Kozlowski
2022-11-14 9:50 ` Yinbo Zhu [this message]
2022-11-18 12:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5457109-3bcb-e7d3-067d-9e4acd66ac17@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=apatard@mandriva.com \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=huhb@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=richard.liu@st.com \
--cc=robh+dt@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).