From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Juxin Gao <gaojuxin@loongson.cn>, Bibo Mao <maobibo@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, richard.liu@st.com,
Arnaud Patard <apatard@mandriva.com>,
Hongbing Hu <huhb@lemote.com>,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio
Date: Fri, 18 Nov 2022 13:38:44 +0100 [thread overview]
Message-ID: <947bc72f-2273-9474-9af4-5532d69491b2@linaro.org> (raw)
In-Reply-To: <d5457109-3bcb-e7d3-067d-9e4acd66ac17@loongson.cn>
On 14/11/2022 10:50, Yinbo Zhu wrote:
>
>>> +
>>> + "#gpio-cells":
>>> + const: 2
>>> +
>>> + gpio-controller: true
>>> +
>>> + gpio-ranges: true
>>> +
>>> + loongson,conf_offset:
>>
>> No underscores in node names. Plus comments from Linus seem to apply
>> here as well. Drop it entirely or explain why this is not part of
>> compatible, why this is needed and why encoding programming model
>> address in DT matches the DT...
> Add it is to distinguish differnt address in different platform.
> and I had drop them and initial them in kernel driver that depend
> on diffent compatible.
>>
So if you had to drop these, please drop from the bindings.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-18 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:21 [PATCH v1 1/2] gpio: loongson: add dts/acpi gpio support Yinbo Zhu
2022-11-08 9:21 ` [PATCH v1 2/2] dt-bindings: gpio: add loongson series gpio Yinbo Zhu
2022-11-08 12:11 ` Linus Walleij
2022-11-08 15:28 ` Krzysztof Kozlowski
2022-11-14 9:50 ` Yinbo Zhu
2022-11-18 12:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=947bc72f-2273-9474-9af4-5532d69491b2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=apatard@mandriva.com \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=huhb@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=richard.liu@st.com \
--cc=robh+dt@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).