* [PATCH] mm/slub: page is always non-NULL for node_match()
@ 2018-11-06 15:02 Wei Yang
2018-11-06 15:56 ` Christopher Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yang @ 2018-11-06 15:02 UTC (permalink / raw)
To: cl, penberg; +Cc: akpm, linux-mm, Wei Yang
node_match() is a static function and only invoked in slub.c.
In all three places, page is ensured to be valid.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 90d26063be68..af8bea511855 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2365,7 +2365,7 @@ static int slub_cpu_dead(unsigned int cpu)
static inline int node_match(struct page *page, int node)
{
#ifdef CONFIG_NUMA
- if (!page || (node != NUMA_NO_NODE && page_to_nid(page) != node))
+ if (node != NUMA_NO_NODE && page_to_nid(page) != node)
return 0;
#endif
return 1;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/slub: page is always non-NULL for node_match()
2018-11-06 15:02 [PATCH] mm/slub: page is always non-NULL for node_match() Wei Yang
@ 2018-11-06 15:56 ` Christopher Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Lameter @ 2018-11-06 15:56 UTC (permalink / raw)
To: Wei Yang; +Cc: penberg, akpm, linux-mm
Acked-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-06 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-06 15:02 [PATCH] mm/slub: page is always non-NULL for node_match() Wei Yang
2018-11-06 15:56 ` Christopher Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).