* [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
@ 2022-09-19 16:39 Maurizio Lombardi
2022-09-19 17:30 ` Vlastimil Babka
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Maurizio Lombardi @ 2022-09-19 16:39 UTC (permalink / raw)
To: vbabka
Cc: linux-mm, rientjes, penberg, iamjoonsoo.kim, akpm, linux-kernel, bigeasy
Commit 5a836bf6b09f ("mm: slub: move flush_cpu_slab() invocations
__free_slab() invocations out of IRQ context") moved all flush_cpu_slab()
invocations to the global workqueue to avoid a problem related
with deactivate_slab()/__free_slab() being called from an IRQ context
on PREEMPT_RT kernels.
When the flush_all_cpu_locked() function is called from a task context
it may happen that a workqueue with WQ_MEM_RECLAIM bit set ends up
flushing the global workqueue, this will cause a dependency issue.
workqueue: WQ_MEM_RECLAIM nvme-delete-wq:nvme_delete_ctrl_work [nvme_core]
is flushing !WQ_MEM_RECLAIM events:flush_cpu_slab
WARNING: CPU: 37 PID: 410 at kernel/workqueue.c:2637
check_flush_dependency+0x10a/0x120
Workqueue: nvme-delete-wq nvme_delete_ctrl_work [nvme_core]
RIP: 0010:check_flush_dependency+0x10a/0x120[ 453.262125] Call Trace:
__flush_work.isra.0+0xbf/0x220
? __queue_work+0x1dc/0x420
flush_all_cpus_locked+0xfb/0x120
__kmem_cache_shutdown+0x2b/0x320
kmem_cache_destroy+0x49/0x100
bioset_exit+0x143/0x190
blk_release_queue+0xb9/0x100
kobject_cleanup+0x37/0x130
nvme_fc_ctrl_free+0xc6/0x150 [nvme_fc]
nvme_free_ctrl+0x1ac/0x2b0 [nvme_core]
Fix this bug by creating a workqueue for the flush operation with
the WQ_MEM_RECLAIM bit set.
v2: Create a workqueue with WQ_MEM_RECLAIM
instead of trying to revert the changes.
v3: replace create_workqueue() with alloc_workqueue() and BUG_ON() with
WARN_ON()
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
mm/slub.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/mm/slub.c b/mm/slub.c
index 862dbd9af4f5..016da09608fb 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -310,6 +310,11 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si)
*/
static nodemask_t slab_nodes;
+/*
+ * Workqueue used for flush_cpu_slab().
+ */
+static struct workqueue_struct *flushwq;
+
/********************************************************************
* Core slab cache functions
*******************************************************************/
@@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
INIT_WORK(&sfw->work, flush_cpu_slab);
sfw->skip = false;
sfw->s = s;
- schedule_work_on(cpu, &sfw->work);
+ queue_work_on(cpu, flushwq, &sfw->work);
}
for_each_online_cpu(cpu) {
@@ -4858,6 +4863,8 @@ void __init kmem_cache_init(void)
void __init kmem_cache_init_late(void)
{
+ flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM, 0);
+ WARN_ON(!flushwq);
}
struct kmem_cache *
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
2022-09-19 16:39 [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
@ 2022-09-19 17:30 ` Vlastimil Babka
2022-09-20 7:46 ` Hyeonggon Yoo
2022-09-20 9:31 ` Hyeonggon Yoo
2 siblings, 0 replies; 6+ messages in thread
From: Vlastimil Babka @ 2022-09-19 17:30 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: linux-mm, rientjes, penberg, iamjoonsoo.kim, akpm, linux-kernel,
bigeasy, Hyeonggon Yoo, Roman Gushchin
On 9/19/22 18:39, Maurizio Lombardi wrote:
> Commit 5a836bf6b09f ("mm: slub: move flush_cpu_slab() invocations
> __free_slab() invocations out of IRQ context") moved all flush_cpu_slab()
> invocations to the global workqueue to avoid a problem related
> with deactivate_slab()/__free_slab() being called from an IRQ context
> on PREEMPT_RT kernels.
>
> When the flush_all_cpu_locked() function is called from a task context
> it may happen that a workqueue with WQ_MEM_RECLAIM bit set ends up
> flushing the global workqueue, this will cause a dependency issue.
>
> workqueue: WQ_MEM_RECLAIM nvme-delete-wq:nvme_delete_ctrl_work [nvme_core]
> is flushing !WQ_MEM_RECLAIM events:flush_cpu_slab
> WARNING: CPU: 37 PID: 410 at kernel/workqueue.c:2637
> check_flush_dependency+0x10a/0x120
> Workqueue: nvme-delete-wq nvme_delete_ctrl_work [nvme_core]
> RIP: 0010:check_flush_dependency+0x10a/0x120[ 453.262125] Call Trace:
> __flush_work.isra.0+0xbf/0x220
> ? __queue_work+0x1dc/0x420
> flush_all_cpus_locked+0xfb/0x120
> __kmem_cache_shutdown+0x2b/0x320
> kmem_cache_destroy+0x49/0x100
> bioset_exit+0x143/0x190
> blk_release_queue+0xb9/0x100
> kobject_cleanup+0x37/0x130
> nvme_fc_ctrl_free+0xc6/0x150 [nvme_fc]
> nvme_free_ctrl+0x1ac/0x2b0 [nvme_core]
>
> Fix this bug by creating a workqueue for the flush operation with
> the WQ_MEM_RECLAIM bit set.
>
> v2: Create a workqueue with WQ_MEM_RECLAIM
> instead of trying to revert the changes.
>
> v3: replace create_workqueue() with alloc_workqueue() and BUG_ON() with
> WARN_ON()
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Thanks, I added a Fixes: and Cc stable as AFAICS the warnings are not under
a debugging config option, and it could bite somebody near OOM. Added to
slab.git for-6.0/fixes and will include in pullrq this week.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
2022-09-19 16:39 [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
2022-09-19 17:30 ` Vlastimil Babka
@ 2022-09-20 7:46 ` Hyeonggon Yoo
2022-09-20 7:56 ` Sebastian Andrzej Siewior
2022-09-20 9:31 ` Hyeonggon Yoo
2 siblings, 1 reply; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-09-20 7:46 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: vbabka, linux-mm, rientjes, penberg, iamjoonsoo.kim, akpm,
linux-kernel, bigeasy
On Mon, Sep 19, 2022 at 06:39:29PM +0200, Maurizio Lombardi wrote:
> Commit 5a836bf6b09f ("mm: slub: move flush_cpu_slab() invocations
> __free_slab() invocations out of IRQ context") moved all flush_cpu_slab()
> invocations to the global workqueue to avoid a problem related
> with deactivate_slab()/__free_slab() being called from an IRQ context
> on PREEMPT_RT kernels.
>
> When the flush_all_cpu_locked() function is called from a task context
> it may happen that a workqueue with WQ_MEM_RECLAIM bit set ends up
> flushing the global workqueue, this will cause a dependency issue.
>
> workqueue: WQ_MEM_RECLAIM nvme-delete-wq:nvme_delete_ctrl_work [nvme_core]
> is flushing !WQ_MEM_RECLAIM events:flush_cpu_slab
> WARNING: CPU: 37 PID: 410 at kernel/workqueue.c:2637
> check_flush_dependency+0x10a/0x120
> Workqueue: nvme-delete-wq nvme_delete_ctrl_work [nvme_core]
> RIP: 0010:check_flush_dependency+0x10a/0x120[ 453.262125] Call Trace:
> __flush_work.isra.0+0xbf/0x220
> ? __queue_work+0x1dc/0x420
> flush_all_cpus_locked+0xfb/0x120
> __kmem_cache_shutdown+0x2b/0x320
> kmem_cache_destroy+0x49/0x100
> bioset_exit+0x143/0x190
> blk_release_queue+0xb9/0x100
> kobject_cleanup+0x37/0x130
> nvme_fc_ctrl_free+0xc6/0x150 [nvme_fc]
> nvme_free_ctrl+0x1ac/0x2b0 [nvme_core]
>
> Fix this bug by creating a workqueue for the flush operation with
> the WQ_MEM_RECLAIM bit set.
>
> v2: Create a workqueue with WQ_MEM_RECLAIM
> instead of trying to revert the changes.
>
> v3: replace create_workqueue() with alloc_workqueue() and BUG_ON() with
> WARN_ON()
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> mm/slub.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 862dbd9af4f5..016da09608fb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -310,6 +310,11 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si)
> */
> static nodemask_t slab_nodes;
>
> +/*
> + * Workqueue used for flush_cpu_slab().
> + */
> +static struct workqueue_struct *flushwq;
> +
> /********************************************************************
> * Core slab cache functions
> *******************************************************************/
> @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> INIT_WORK(&sfw->work, flush_cpu_slab);
> sfw->skip = false;
> sfw->s = s;
> - schedule_work_on(cpu, &sfw->work);
> + queue_work_on(cpu, flushwq, &sfw->work);
Hi. what happens here if flushwq failed?
I think avoiding BUG_ON() makes sense,
but shouldn't we have fallback method?
> }
>
> for_each_online_cpu(cpu) {
> @@ -4858,6 +4863,8 @@ void __init kmem_cache_init(void)
>
> void __init kmem_cache_init_late(void)
> {
> + flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM, 0);
> + WARN_ON(!flushwq);
> }
>
> struct kmem_cache *
> --
> 2.31.1
>
>
--
Thanks,
Hyeonggon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
2022-09-20 7:46 ` Hyeonggon Yoo
@ 2022-09-20 7:56 ` Sebastian Andrzej Siewior
2022-09-20 9:27 ` Hyeonggon Yoo
0 siblings, 1 reply; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2022-09-20 7:56 UTC (permalink / raw)
To: Hyeonggon Yoo
Cc: Maurizio Lombardi, vbabka, linux-mm, rientjes, penberg,
iamjoonsoo.kim, akpm, linux-kernel
On 2022-09-20 16:46:41 [+0900], Hyeonggon Yoo wrote:
> > @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> > INIT_WORK(&sfw->work, flush_cpu_slab);
> > sfw->skip = false;
> > sfw->s = s;
> > - schedule_work_on(cpu, &sfw->work);
> > + queue_work_on(cpu, flushwq, &sfw->work);
>
> Hi. what happens here if flushwq failed?
>
> I think avoiding BUG_ON() makes sense,
> but shouldn't we have fallback method?
You get an output to act on and fix. The point is that it shouldn't have
happen in the first place. With the bug_on() that early, chances are
that you never see anything but a blank screen. So with the warn_on you
get probably to see the warn_on before you get here.
Sebastian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
2022-09-20 7:56 ` Sebastian Andrzej Siewior
@ 2022-09-20 9:27 ` Hyeonggon Yoo
0 siblings, 0 replies; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-09-20 9:27 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Maurizio Lombardi, vbabka, linux-mm, rientjes, penberg,
iamjoonsoo.kim, akpm, linux-kernel
On Tue, Sep 20, 2022 at 09:56:59AM +0200, Sebastian Andrzej Siewior wrote:
> On 2022-09-20 16:46:41 [+0900], Hyeonggon Yoo wrote:
> > > @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> > > INIT_WORK(&sfw->work, flush_cpu_slab);
> > > sfw->skip = false;
> > > sfw->s = s;
> > > - schedule_work_on(cpu, &sfw->work);
> > > + queue_work_on(cpu, flushwq, &sfw->work);
> >
> > Hi. what happens here if flushwq failed?
> >
> > I think avoiding BUG_ON() makes sense,
> > but shouldn't we have fallback method?
>
> You get an output to act on and fix. The point is that it shouldn't have
> happen in the first place. With the bug_on() that early, chances are
> that you never see anything but a blank screen. So with the warn_on you
> get probably to see the warn_on before you get here.
>
> Sebastian
Thank you for kind explanation.
Makes sense!
--
Thanks,
Hyeonggon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context.
2022-09-19 16:39 [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
2022-09-19 17:30 ` Vlastimil Babka
2022-09-20 7:46 ` Hyeonggon Yoo
@ 2022-09-20 9:31 ` Hyeonggon Yoo
2 siblings, 0 replies; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-09-20 9:31 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: vbabka, linux-mm, rientjes, penberg, iamjoonsoo.kim, akpm,
linux-kernel, bigeasy
On Mon, Sep 19, 2022 at 06:39:29PM +0200, Maurizio Lombardi wrote:
> Commit 5a836bf6b09f ("mm: slub: move flush_cpu_slab() invocations
> __free_slab() invocations out of IRQ context") moved all flush_cpu_slab()
> invocations to the global workqueue to avoid a problem related
> with deactivate_slab()/__free_slab() being called from an IRQ context
> on PREEMPT_RT kernels.
>
> When the flush_all_cpu_locked() function is called from a task context
> it may happen that a workqueue with WQ_MEM_RECLAIM bit set ends up
> flushing the global workqueue, this will cause a dependency issue.
>
> workqueue: WQ_MEM_RECLAIM nvme-delete-wq:nvme_delete_ctrl_work [nvme_core]
> is flushing !WQ_MEM_RECLAIM events:flush_cpu_slab
> WARNING: CPU: 37 PID: 410 at kernel/workqueue.c:2637
> check_flush_dependency+0x10a/0x120
> Workqueue: nvme-delete-wq nvme_delete_ctrl_work [nvme_core]
> RIP: 0010:check_flush_dependency+0x10a/0x120[ 453.262125] Call Trace:
> __flush_work.isra.0+0xbf/0x220
> ? __queue_work+0x1dc/0x420
> flush_all_cpus_locked+0xfb/0x120
> __kmem_cache_shutdown+0x2b/0x320
> kmem_cache_destroy+0x49/0x100
> bioset_exit+0x143/0x190
> blk_release_queue+0xb9/0x100
> kobject_cleanup+0x37/0x130
> nvme_fc_ctrl_free+0xc6/0x150 [nvme_fc]
> nvme_free_ctrl+0x1ac/0x2b0 [nvme_core]
>
> Fix this bug by creating a workqueue for the flush operation with
> the WQ_MEM_RECLAIM bit set.
>
> v2: Create a workqueue with WQ_MEM_RECLAIM
> instead of trying to revert the changes.
>
> v3: replace create_workqueue() with alloc_workqueue() and BUG_ON() with
> WARN_ON()
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> mm/slub.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 862dbd9af4f5..016da09608fb 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -310,6 +310,11 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si)
> */
> static nodemask_t slab_nodes;
>
> +/*
> + * Workqueue used for flush_cpu_slab().
> + */
> +static struct workqueue_struct *flushwq;
> +
> /********************************************************************
> * Core slab cache functions
> *******************************************************************/
> @@ -2730,7 +2735,7 @@ static void flush_all_cpus_locked(struct kmem_cache *s)
> INIT_WORK(&sfw->work, flush_cpu_slab);
> sfw->skip = false;
> sfw->s = s;
> - schedule_work_on(cpu, &sfw->work);
> + queue_work_on(cpu, flushwq, &sfw->work);
> }
>
> for_each_online_cpu(cpu) {
> @@ -4858,6 +4863,8 @@ void __init kmem_cache_init(void)
>
> void __init kmem_cache_init_late(void)
> {
> + flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM, 0);
> + WARN_ON(!flushwq);
> }
>
> struct kmem_cache *
> --
> 2.31.1
>
Looks good to me.
Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
--
Thanks,
Hyeonggon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-20 9:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 16:39 [PATCH V3] mm: slub: fix flush_cpu_slab()/__free_slab() invocations in task context Maurizio Lombardi
2022-09-19 17:30 ` Vlastimil Babka
2022-09-20 7:46 ` Hyeonggon Yoo
2022-09-20 7:56 ` Sebastian Andrzej Siewior
2022-09-20 9:27 ` Hyeonggon Yoo
2022-09-20 9:31 ` Hyeonggon Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).