From: David Hildenbrand <david@redhat.com>
To: Rebecca Mckeever <remckee0@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options
Date: Wed, 22 Jun 2022 12:00:05 +0200 [thread overview]
Message-ID: <0754cefe-e8e1-6eec-cad0-35c081c880d7@redhat.com> (raw)
In-Reply-To: <cover.1655889641.git.remckee0@gmail.com>
On 22.06.22 11:29, Rebecca Mckeever wrote:
> These patches add options VERBOSE and MEMBLOCK_DEBUG to Memblock
> simulator, which can be specified when running make. These patches also
> implement the functionality for these options.
>
> VERBOSE
> Usage:
>
> $ make VERBOSE=1
>
> Passing VERBOSE=1 will enable verbose output from Memblock simulator. For
> each test, the verbose output includes the name of the memblock function
> being tested, the name of the test, and whether the test passed or failed.
> Since all the tests in Memblock simulator run as one monolithic test, this
> output is a quick way to get a summary of test results.
>
> MEMBLOCK_DEBUG
> Usage:
>
> $ make MEMBLOCK_DEBUG=1
>
> Passing MEMBLOCK_DEBUG=1 will enable memblock_dbg() messages. These
> are debug messages built into several functions in memblock that include
> information such as the name of the function and the size and start and
> end addresses of the memblock region.
>
> Rebecca Mckeever (4):
> memblock tests: add user-provided arguments to Makefile
> memblock tests: add verbose output to memblock tests
> memblock tests: set memblock_debug to enable memblock_dbg() messages
> memblock tests: remove completed TODO items
>
> tools/testing/memblock/Makefile | 4 +
> tools/testing/memblock/README | 10 +-
> tools/testing/memblock/TODO | 14 +-
> tools/testing/memblock/internal.h | 7 +
> .../testing/memblock/scripts/Makefile.include | 10 +
> tools/testing/memblock/tests/alloc_api.c | 241 ++++++++----
> .../memblock/tests/alloc_helpers_api.c | 135 +++++--
> tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------
> tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++-----
> tools/testing/memblock/tests/common.c | 58 +++
> tools/testing/memblock/tests/common.h | 54 +++
> 11 files changed, 913 insertions(+), 356 deletions(-)
>
> ---
> Changes
>
> v1 -> v2
> PATCH 2, in common.c:
> Remove #ifdef VERBOSE around prefixes and related constants
> Add __maybe_unused to prefixes
> Move PREFIXES_LEN_MAX, DELIM, and DELIM_LEN so that they are
> immediately after the other constants
> Add #ifdef VERBOSE around definitions for test_*() and prefix_*()
>
> v2 -> v3
> PATCH 1:
> Add Reviewed-by tag
> ---
>
Hi Rebecca,
no need to resend a new version that frequently; wait for more feedback
first.
Usually, people expect a new version when there hasn't been more review
feedback for a few days.
Also, there is usually no need to send a new version when you get a
rb/ack tag: the maintainer might just pick them up when applying the
patches.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-06-22 10:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 9:29 [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Rebecca Mckeever
2022-06-22 9:29 ` [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile Rebecca Mckeever
2022-06-23 3:47 ` Mike Rapoport
2022-06-23 4:45 ` Rebecca Mckeever
2022-06-23 4:52 ` Mike Rapoport
2022-06-22 9:29 ` [PATCH v3 2/4] memblock tests: add verbose output to memblock tests Rebecca Mckeever
2022-06-22 10:32 ` Huang, Shaoqin
2022-06-23 0:45 ` Rebecca Mckeever
2022-06-23 1:29 ` Huang, Shaoqin
2022-06-23 3:10 ` Rebecca Mckeever
2022-06-23 4:05 ` Mike Rapoport
2022-06-23 4:56 ` Rebecca Mckeever
2022-06-23 5:04 ` Mike Rapoport
2022-06-23 7:57 ` Rebecca Mckeever
2022-06-23 13:11 ` Mike Rapoport
2022-06-23 3:37 ` Ira Weiny
2022-06-23 7:25 ` Rebecca Mckeever
2022-06-23 4:30 ` Mike Rapoport
2022-06-23 6:30 ` Rebecca Mckeever
2022-06-23 14:40 ` Mike Rapoport
2022-06-24 7:18 ` Rebecca Mckeever
2022-06-22 9:29 ` [PATCH v3 4/4] memblock tests: remove completed TODO items Rebecca Mckeever
2022-06-22 10:00 ` David Hildenbrand [this message]
2022-06-22 14:17 ` [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Mike Rapoport
2022-06-23 1:01 ` Rebecca Mckeever
2022-06-23 3:30 ` Ira Weiny
2022-06-23 4:20 ` Rebecca Mckeever
2022-06-23 4:38 ` Mike Rapoport
2022-06-23 5:48 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0754cefe-e8e1-6eec-cad0-35c081c880d7@redhat.com \
--to=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=remckee0@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).