From: Mike Rapoport <rppt@kernel.org>
To: Rebecca Mckeever <remckee0@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile
Date: Wed, 22 Jun 2022 23:52:17 -0500 [thread overview]
Message-ID: <YrPxgRzW0OYjyvti@kernel.org> (raw)
In-Reply-To: <YrPv8BnNWyqgwOMo@bertie>
On Wed, Jun 22, 2022 at 11:45:36PM -0500, Rebecca Mckeever wrote:
> Hi Mike,
>
> On Wed, Jun 22, 2022 at 10:47:55PM -0500, Mike Rapoport wrote:
> > Hi Rebecca,
> >
> > On Wed, Jun 22, 2022 at 04:29:06AM -0500, Rebecca Mckeever wrote:
> > >
> > > Subject: memblock tests: add user-provided arguments to Makefile
> >
> > Please be more specific here, e.g.
> >
> > memblock tests: Makefile: add arguments to control verbosity
> >
>
> Should I also mention debug messages, or does verbosity refer to both
> arguments?
It does as enabling memblock_dbg() is also about overall verbosity.
But if you manage to squeeze both in 75 characters I won't mind :)
> > > Add VERBOSE and MEMBLOCK_DEBUG user-provided arguments. VERBOSE will
> > > enable verbose output from Memblock simulator. MEMBLOCK_DEBUG will enable
> > > memblock_dbg() messages.
> > >
> > > Update the help message to include VERBOSE and MEMBLOCK_DEBUG. Update
> > > the README to include VERBOSE. The README does not include all available
> > > options and refers to the help message for the remaining options.
> > > Therefore, omit MEMBLOCK_DEBUG from README.
> > >
> > > Reviewed-by: David Hildenbrand <david@redhat.com>
> > > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> > > ---
> > > tools/testing/memblock/Makefile | 4 ++++
> > > tools/testing/memblock/README | 10 +++++++++-
> > > tools/testing/memblock/scripts/Makefile.include | 10 ++++++++++
> > > 3 files changed, 23 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile
> > > index a698e24b35e7..9fde49ad73bd 100644
> > > --- a/tools/testing/memblock/Makefile
> > > +++ b/tools/testing/memblock/Makefile
> > > @@ -45,6 +45,10 @@ help:
> > > @echo ' clean - Remove generated files and symlinks in the directory'
> > > @echo ''
> > > @echo 'Configuration:'
> > > + @echo ' make VERBOSE=1 - enable verbose output, which includes the'
> > > + @echo ' names of functions being tested and the'
> > > + @echo ' number of test cases passing'
> > > + @echo ' make MEMBLOCK_DEBUG=1 - enable memblock_dbg() messages'
> > > @echo ' make NUMA=1 - simulate enabled NUMA'
> > > @echo ' make MOVABLE_NODE=1 - override `movable_node_is_enabled`'
> > > @echo ' definition to simulate movable NUMA nodes'
> > > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README
> > > index ca6afcff013a..058146b528a5 100644
> > > --- a/tools/testing/memblock/README
> > > +++ b/tools/testing/memblock/README
> > > @@ -34,7 +34,15 @@ To run the tests, build the main target and run it:
> > > $ make && ./main
> > >
> > > A successful run produces no output. It is also possible to override different
> > > -configuration parameters. For example, to simulate enabled NUMA, use:
> > > +configuration parameters. For example, to include verbose output, specify the
> > > +VERBOSE flag when building the main target:
> > > +
> > > +$ make VERBOSE=1
> > > +
> > > +This will print information about which functions are being tested and the
> > > +number of test cases that passed.
> > > +
> > > +To simulate enabled NUMA, use:
> > >
> > > $ make NUMA=1
> > >
> > > diff --git a/tools/testing/memblock/scripts/Makefile.include b/tools/testing/memblock/scripts/Makefile.include
> > > index 641569ccb7b0..4401f79bed4c 100644
> > > --- a/tools/testing/memblock/scripts/Makefile.include
> > > +++ b/tools/testing/memblock/scripts/Makefile.include
> > > @@ -17,3 +17,13 @@ ifeq ($(32BIT_PHYS_ADDR_T), 1)
> > > CFLAGS += -m32 -U CONFIG_PHYS_ADDR_T_64BIT
> > > LDFLAGS += -m32
> > > endif
> > > +
> > > +# Enable verbose testing output
> > > +ifeq ($(VERBOSE), 1)
> > > + CFLAGS += -D VERBOSE
> > > +endif
> > > +
> > > +# Enable memblock_dbg() messages
> > > +ifeq ($(MEMBLOCK_DEBUG), 1)
> > > + CFLAGS += -D MEMBLOCK_DEBUG
> > > +endif
> > > --
> > > 2.34.1
> > >
> >
> > --
> > Sincerely yours,
> > Mike.
>
> Thanks,
> Rebecca
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2022-06-23 4:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 9:29 [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Rebecca Mckeever
2022-06-22 9:29 ` [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile Rebecca Mckeever
2022-06-23 3:47 ` Mike Rapoport
2022-06-23 4:45 ` Rebecca Mckeever
2022-06-23 4:52 ` Mike Rapoport [this message]
2022-06-22 9:29 ` [PATCH v3 2/4] memblock tests: add verbose output to memblock tests Rebecca Mckeever
2022-06-22 10:32 ` Huang, Shaoqin
2022-06-23 0:45 ` Rebecca Mckeever
2022-06-23 1:29 ` Huang, Shaoqin
2022-06-23 3:10 ` Rebecca Mckeever
2022-06-23 4:05 ` Mike Rapoport
2022-06-23 4:56 ` Rebecca Mckeever
2022-06-23 5:04 ` Mike Rapoport
2022-06-23 7:57 ` Rebecca Mckeever
2022-06-23 13:11 ` Mike Rapoport
2022-06-23 3:37 ` Ira Weiny
2022-06-23 7:25 ` Rebecca Mckeever
2022-06-23 4:30 ` Mike Rapoport
2022-06-23 6:30 ` Rebecca Mckeever
2022-06-23 14:40 ` Mike Rapoport
2022-06-24 7:18 ` Rebecca Mckeever
2022-06-22 9:29 ` [PATCH v3 4/4] memblock tests: remove completed TODO items Rebecca Mckeever
2022-06-22 10:00 ` [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options David Hildenbrand
2022-06-22 14:17 ` Mike Rapoport
2022-06-23 1:01 ` Rebecca Mckeever
2022-06-23 3:30 ` Ira Weiny
2022-06-23 4:20 ` Rebecca Mckeever
2022-06-23 4:38 ` Mike Rapoport
2022-06-23 5:48 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrPxgRzW0OYjyvti@kernel.org \
--to=rppt@kernel.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=remckee0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).