From: John Hubbard <jhubbard@nvidia.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v4 1/4] mm: Don't skip swap entry even if zap_details specified
Date: Wed, 16 Feb 2022 21:45:13 -0800 [thread overview]
Message-ID: <0c71b2e6-894d-8a36-533c-f5ff8b5e2683@nvidia.com> (raw)
In-Reply-To: <Yg3TKD6i9JjoRe80@xz-m1.local>
On 2/16/22 20:46, Peter Xu wrote:
...
> I personally used 78/79 col width for a long time for different projects, but
> sure I can adjust my config. I found that the "official guide" points us to
> 75 instead:
>
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
>
> The body of the explanation, line wrapped at 75 columns, which will be copied
> to the permanent changelog to describe this patch.
>
> I'll follow that.
>
Oh, I'll change to that too, then. Thanks for spotting that.
> [...]
>>> + if (!should_zap_cows(details))
>>> + continue;
>>> rss[MM_SWAPENTS]--;
>>> - else if (is_migration_entry(entry)) {
>>
>> Can we put a newline here, and before each "else" block? Because now it
>> is getting very dense, and the visual separation really helps.
>
> The thing is we don't have a rule to add empty lines here, or do we? Changing
> it could make it less like what we have had.
>
I'm not claiming rules or standards, this is just a special case of trying
to make it a little nicer. No big deal either way, of course.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-02-17 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 9:48 [PATCH v4 0/4] mm: Rework zap ptes on swap entries Peter Xu
2022-02-16 9:48 ` [PATCH v4 1/4] mm: Don't skip swap entry even if zap_details specified Peter Xu
2022-02-17 2:54 ` Andrew Morton
2022-02-17 4:22 ` Peter Xu
2022-02-17 3:15 ` John Hubbard
2022-02-17 4:46 ` Peter Xu
2022-02-17 5:45 ` John Hubbard [this message]
2022-02-16 9:48 ` [PATCH v4 2/4] mm: Rename zap_skip_check_mapping() to should_zap_page() Peter Xu
2022-02-17 3:18 ` John Hubbard
2022-02-16 9:48 ` [PATCH v4 3/4] mm: Change zap_details.zap_mapping into even_cows Peter Xu
2022-02-17 3:19 ` John Hubbard
2022-02-16 9:48 ` [PATCH v4 4/4] mm: Rework swap handling of zap_pte_range Peter Xu
2022-02-17 3:25 ` John Hubbard
2022-02-17 4:54 ` Peter Xu
2022-02-17 5:46 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c71b2e6-894d-8a36-533c-f5ff8b5e2683@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).