From: John Hubbard <jhubbard@nvidia.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v4 4/4] mm: Rework swap handling of zap_pte_range
Date: Wed, 16 Feb 2022 19:25:14 -0800 [thread overview]
Message-ID: <b04fabea-6216-3808-44e8-0a2125bf0230@nvidia.com> (raw)
In-Reply-To: <20220216094810.60572-5-peterx@redhat.com>
On 2/16/22 1:48 AM, Peter Xu wrote:
> Clean the code up by merging the device private/exclusive swap entry handling
> with the rest, then we merge the pte clear operation too.
Maybe also mention that you reduced the code duplication in the
is_device_private_entry() area, by letting it fall through to the common
pte_clear_not_present_full() at the end of the loop? Since you're listing
the other changes, that one seems worth mentioning.
>
> struct* page is defined in multiple places in the function, move it upward.
>
> free_swap_and_cache() is only useful for !non_swap_entry() case, put it into
> the condition.
>
> No functional change intended.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> mm/memory.c | 21 ++++++---------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index ffa8c7dfe9ad..cade96024349 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1361,6 +1361,8 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> arch_enter_lazy_mmu_mode();
> do {
> pte_t ptent = *pte;
> + struct page *page;
> +
> if (pte_none(ptent))
> continue;
>
> @@ -1368,8 +1370,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> break;
>
> if (pte_present(ptent)) {
> - struct page *page;
> -
> page = vm_normal_page(vma, addr, ptent);
> if (unlikely(!should_zap_page(details, page)))
> continue;
> @@ -1403,21 +1403,14 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> entry = pte_to_swp_entry(ptent);
> if (is_device_private_entry(entry) ||
> is_device_exclusive_entry(entry)) {
> - struct page *page = pfn_swap_entry_to_page(entry);
> -
> + page = pfn_swap_entry_to_page(entry);
> if (unlikely(!should_zap_page(details, page)))
> continue;
> - pte_clear_not_present_full(mm, addr, pte, tlb->fullmm);
Yes! Good cleanup there.
> rss[mm_counter(page)]--;
> -
> if (is_device_private_entry(entry))
> page_remove_rmap(page, false);
> -
> put_page(page);
> - continue;
> - }
> -
> - if (!non_swap_entry(entry)) {
> + } else if (!non_swap_entry(entry)) {
> /*
> * If this is a genuine swap entry, then it must be an
> * private anon page. If the caller wants to skip
> @@ -1426,9 +1419,9 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> if (!should_zap_cows(details))
> continue;
> rss[MM_SWAPENTS]--;
> + if (unlikely(!free_swap_and_cache(entry)))
> + print_bad_pte(vma, addr, ptent, NULL);
> } else if (is_migration_entry(entry)) {
> - struct page *page;
> -
> page = pfn_swap_entry_to_page(entry);
> if (!should_zap_page(details, page))
> continue;
> @@ -1441,8 +1434,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> /* We should have covered all the swap entry types */
> WARN_ON_ONCE(1);
> }
> - if (unlikely(!free_swap_and_cache(entry)))
> - print_bad_pte(vma, addr, ptent, NULL);
> pte_clear_not_present_full(mm, addr, pte, tlb->fullmm);
> } while (pte++, addr += PAGE_SIZE, addr != end);
>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-02-17 3:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 9:48 [PATCH v4 0/4] mm: Rework zap ptes on swap entries Peter Xu
2022-02-16 9:48 ` [PATCH v4 1/4] mm: Don't skip swap entry even if zap_details specified Peter Xu
2022-02-17 2:54 ` Andrew Morton
2022-02-17 4:22 ` Peter Xu
2022-02-17 3:15 ` John Hubbard
2022-02-17 4:46 ` Peter Xu
2022-02-17 5:45 ` John Hubbard
2022-02-16 9:48 ` [PATCH v4 2/4] mm: Rename zap_skip_check_mapping() to should_zap_page() Peter Xu
2022-02-17 3:18 ` John Hubbard
2022-02-16 9:48 ` [PATCH v4 3/4] mm: Change zap_details.zap_mapping into even_cows Peter Xu
2022-02-17 3:19 ` John Hubbard
2022-02-16 9:48 ` [PATCH v4 4/4] mm: Rework swap handling of zap_pte_range Peter Xu
2022-02-17 3:25 ` John Hubbard [this message]
2022-02-17 4:54 ` Peter Xu
2022-02-17 5:46 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b04fabea-6216-3808-44e8-0a2125bf0230@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).