From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-mm@kvack.org>, <nouveau@lists.freedesktop.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jerome Glisse" <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Bharata B Rao <bharata@linux.ibm.com>, Zi Yan <ziy@nvidia.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Ben Skeggs <bskeggs@redhat.com>, Shuah Khan <shuah@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 3/6] mm: support THP migration to device private memory
Date: Mon, 9 Nov 2020 13:34:17 -0800 [thread overview]
Message-ID: <0ed2fbec-e855-9be5-4897-523b00391a5a@nvidia.com> (raw)
In-Reply-To: <20201109091415.GC28918@lst.de>
On 11/9/20 1:14 AM, Christoph Hellwig wrote:
> On Fri, Nov 06, 2020 at 01:26:50PM -0800, Ralph Campbell wrote:
>>
>> On 11/6/20 12:03 AM, Christoph Hellwig wrote:
>>> I hate the extra pin count magic here. IMHO we really need to finish
>>> off the series to get rid of the extra references on the ZONE_DEVICE
>>> pages first.
>>
>> First, thanks for the review comments.
>>
>> I don't like the extra refcount either, that is why I tried to fix that up
>> before resending this series. However, you didn't like me just fixing the
>> refcount only for device private pages and I don't know the dax/pmem code
>> and peer-to-peer PCIe uses of ZONE_DEVICE pages well enough to say how
>> long it will take me to fix all the use cases.
>> So I wanted to make progress on the THP migration code in the mean time.
>
> I think P2P is pretty trivial, given that ZONE_DEVICE pages are used like
> a normal memory allocator. DAX is the interesting case, any specific
> help that you need with that?
Thanks for the offer. I'm putting a list together... :-)
next prev parent reply other threads:[~2020-11-09 21:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:51 [PATCH v3 0/6] mm/hmm/nouveau: add THP migration to migrate_vma_* Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 1/6] mm/thp: add prep_transhuge_device_private_page() Ralph Campbell
2020-11-06 7:55 ` Christoph Hellwig
2020-11-06 20:56 ` Ralph Campbell
2020-11-06 12:14 ` Matthew Wilcox
2020-11-06 20:34 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 2/6] mm/migrate: move migrate_vma_collect_skip() Ralph Campbell
2020-11-06 7:56 ` Christoph Hellwig
2020-11-06 7:57 ` Christoph Hellwig
2020-11-06 0:51 ` [PATCH v3 3/6] mm: support THP migration to device private memory Ralph Campbell
2020-11-06 8:03 ` Christoph Hellwig
2020-11-06 21:26 ` Ralph Campbell
2020-11-09 9:14 ` Christoph Hellwig
2020-11-09 21:34 ` Ralph Campbell [this message]
2020-11-11 23:38 ` Ralph Campbell
2020-11-20 20:01 ` Jason Gunthorpe
2020-12-02 10:08 ` Christoph Hellwig
2020-12-05 8:22 ` Roger Pau Monné
2020-12-02 10:14 ` Christoph Hellwig
2020-12-02 18:01 ` Logan Gunthorpe
2020-11-06 0:51 ` [PATCH v3 4/6] mm/thp: add THP allocation helper Ralph Campbell
2020-11-06 8:01 ` Christoph Hellwig
2020-11-06 21:09 ` Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 5/6] mm/hmm/test: add self tests for THP migration Ralph Campbell
2020-11-06 0:51 ` [PATCH v3 6/6] nouveau: support THP migration to private memory Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed2fbec-e855-9be5-4897-523b00391a5a@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=shuah@kernel.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).