* [PATCH][mm-next] mm: clean up build warning with unused variable ret2
@ 2017-06-21 10:14 Colin King
2017-06-21 10:22 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-21 10:14 UTC (permalink / raw)
To: Andrew Morton, Johannes Weiner, Mel Gorman, Jan Kara,
Michal Hocko, Jeff Layton, Dave Chinner, Matthew Wilcox,
Sebastian Andrzej Siewior, linux-mm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable ret2 is unused and should be removed. Cleans up
build warning:
warning: unused variable 'ret2' [-Wunused-variable]
Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 64b75bd996a4..0b60cc7ddac2 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
int write_one_page(struct page *page)
{
struct address_space *mapping = page->mapping;
- int ret = 0, ret2;
+ int ret = 0;
struct writeback_control wbc = {
.sync_mode = WB_SYNC_ALL,
.nr_to_write = 1,
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][mm-next] mm: clean up build warning with unused variable ret2
2017-06-21 10:14 [PATCH][mm-next] mm: clean up build warning with unused variable ret2 Colin King
@ 2017-06-21 10:22 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2017-06-21 10:22 UTC (permalink / raw)
To: Colin King, Andrew Morton, Johannes Weiner, Mel Gorman, Jan Kara,
Michal Hocko, Dave Chinner, Matthew Wilcox,
Sebastian Andrzej Siewior, linux-mm
Cc: kernel-janitors, linux-kernel
On Wed, 2017-06-21 at 11:14 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ret2 is unused and should be removed. Cleans up
> build warning:
>
> warning: unused variable 'ret2' [-Wunused-variable]
>
> Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 64b75bd996a4..0b60cc7ddac2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
> int write_one_page(struct page *page)
> {
> struct address_space *mapping = page->mapping;
> - int ret = 0, ret2;
> + int ret = 0;
> struct writeback_control wbc = {
> .sync_mode = WB_SYNC_ALL,
> .nr_to_write = 1,
Thanks. I just squashed the same fix into the original patch this
morning after seeing the mail from Stephen. Tomorrow's linux-next pull
should pick up the corrected version.
--
Jeff Layton <jlayton@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-21 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 10:14 [PATCH][mm-next] mm: clean up build warning with unused variable ret2 Colin King
2017-06-21 10:22 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).