* [PATCH] mm/compaction: fix the comment for try_to_compact_pages
@ 2018-01-12 23:55 Yang Shi
2018-01-17 8:43 ` Vlastimil Babka
0 siblings, 1 reply; 2+ messages in thread
From: Yang Shi @ 2018-01-12 23:55 UTC (permalink / raw)
To: akpm
Cc: yang.shi, linux-mm, linux-kernel, Vlastimil Babka, Mel Gorman,
David Rientjes, Joonsoo Kim, Michal Hocko
"mode" argument is not used by try_to_compact_pages() and sub functions
anymore, it has been replaced by "prio". Fix the comment to explain the
use of "prio" argument.
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 10cd757..2c8999d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1738,7 +1738,7 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
* @order: The order of the current allocation
* @alloc_flags: The allocation flags of the current allocation
* @ac: The context of current allocation
- * @mode: The migration mode for async, sync light, or sync migration
+ * @prio: Determines how hard direct compaction should try to succeed
*
* This is the main entry point for direct page compaction.
*/
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/compaction: fix the comment for try_to_compact_pages
2018-01-12 23:55 [PATCH] mm/compaction: fix the comment for try_to_compact_pages Yang Shi
@ 2018-01-17 8:43 ` Vlastimil Babka
0 siblings, 0 replies; 2+ messages in thread
From: Vlastimil Babka @ 2018-01-17 8:43 UTC (permalink / raw)
To: Yang Shi, akpm
Cc: linux-mm, linux-kernel, Mel Gorman, David Rientjes, Joonsoo Kim,
Michal Hocko
On 01/13/2018 12:55 AM, Yang Shi wrote:
> "mode" argument is not used by try_to_compact_pages() and sub functions
> anymore, it has been replaced by "prio". Fix the comment to explain the
> use of "prio" argument.
>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 10cd757..2c8999d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1738,7 +1738,7 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
> * @order: The order of the current allocation
> * @alloc_flags: The allocation flags of the current allocation
> * @ac: The context of current allocation
> - * @mode: The migration mode for async, sync light, or sync migration
> + * @prio: Determines how hard direct compaction should try to succeed
> *
> * This is the main entry point for direct page compaction.
> */
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-17 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 23:55 [PATCH] mm/compaction: fix the comment for try_to_compact_pages Yang Shi
2018-01-17 8:43 ` Vlastimil Babka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).