* [PATCH 1/3] arm: remove ARCH_SELECT_MEMORY_MODEL
2019-05-01 19:56 [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
@ 2019-05-01 19:56 ` Mike Rapoport
2019-05-01 19:56 ` [PATCH 2/3] s390: " Mike Rapoport
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2019-05-01 19:56 UTC (permalink / raw)
To: Andrew Morton
Cc: Arnd Bergmann, Christoph Hellwig, David S. Miller,
Heiko Carstens, Martin Schwidefsky, Russell King,
linux-arm-kernel, linux-s390, sparclinux, linux-arch, linux-mm,
linux-kernel, Mike Rapoport
The ARCH_SELECT_MEMORY_MODEL in arch/arm/Kconfig is enabled only when
ARCH_SPARSEMEM_ENABLE=y. But in this case, ARCH_SPARSEMEM_DEFAULT is also
enabled and this in turn enables SPARSEMEM_MANUAL.
Since there is no definition of ARCH_FLATMEM_ENABLE in arch/arm/Kconfig,
SPARSEMEM_MANUAL is the only enabled memory model, hence the final
selection will evaluate to SPARSEMEM=y.
Since ARCH_SPARSEMEM_ENABLE is set to 'y' only by several sub-arch
configurations, the default for must sub-arches would be the falback to
FLATMEM regardless of ARCH_SELECT_MEMORY_MODEL.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/arm/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 9aed25a..25a69a3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1592,9 +1592,6 @@ config ARCH_SPARSEMEM_ENABLE
config ARCH_SPARSEMEM_DEFAULT
def_bool ARCH_SPARSEMEM_ENABLE
-config ARCH_SELECT_MEMORY_MODEL
- def_bool ARCH_SPARSEMEM_ENABLE
-
config HAVE_ARCH_PFN_VALID
def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] s390: remove ARCH_SELECT_MEMORY_MODEL
2019-05-01 19:56 [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
2019-05-01 19:56 ` [PATCH 1/3] arm: remove ARCH_SELECT_MEMORY_MODEL Mike Rapoport
@ 2019-05-01 19:56 ` Mike Rapoport
2019-05-03 13:47 ` Heiko Carstens
2019-05-01 19:56 ` [PATCH 3/3] sparc: " Mike Rapoport
2019-05-16 5:19 ` [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
3 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2019-05-01 19:56 UTC (permalink / raw)
To: Andrew Morton
Cc: Arnd Bergmann, Christoph Hellwig, David S. Miller,
Heiko Carstens, Martin Schwidefsky, Russell King,
linux-arm-kernel, linux-s390, sparclinux, linux-arch, linux-mm,
linux-kernel, Mike Rapoport
The only reason s390 has ARCH_SELECT_MEMORY_MODEL option in
arch/s390/Kconfig is an ancient compile error with allnoconfig which was
fixed by commit 97195d6b411f ("[S390] fix sparsemem related compile error
with allnoconfig on s390") by adding the ARCH_SELECT_MEMORY_MODEL option.
Since then a lot have changed and now allnoconfig builds just fine without
ARCH_SELECT_MEMORY_MODEL, so it can be removed.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/s390/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index b6e3d06..69d3956 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -621,9 +621,6 @@ config ARCH_SPARSEMEM_ENABLE
config ARCH_SPARSEMEM_DEFAULT
def_bool y
-config ARCH_SELECT_MEMORY_MODEL
- def_bool y
-
config ARCH_ENABLE_MEMORY_HOTPLUG
def_bool y if SPARSEMEM
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] s390: remove ARCH_SELECT_MEMORY_MODEL
2019-05-01 19:56 ` [PATCH 2/3] s390: " Mike Rapoport
@ 2019-05-03 13:47 ` Heiko Carstens
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Carstens @ 2019-05-03 13:47 UTC (permalink / raw)
To: Mike Rapoport
Cc: Andrew Morton, Arnd Bergmann, Christoph Hellwig, David S. Miller,
Martin Schwidefsky, Russell King, linux-arm-kernel, linux-s390,
sparclinux, linux-arch, linux-mm, linux-kernel
On Wed, May 01, 2019 at 10:56:16PM +0300, Mike Rapoport wrote:
> The only reason s390 has ARCH_SELECT_MEMORY_MODEL option in
> arch/s390/Kconfig is an ancient compile error with allnoconfig which was
> fixed by commit 97195d6b411f ("[S390] fix sparsemem related compile error
> with allnoconfig on s390") by adding the ARCH_SELECT_MEMORY_MODEL option.
>
> Since then a lot have changed and now allnoconfig builds just fine without
> ARCH_SELECT_MEMORY_MODEL, so it can be removed.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/s390/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] sparc: remove ARCH_SELECT_MEMORY_MODEL
2019-05-01 19:56 [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
2019-05-01 19:56 ` [PATCH 1/3] arm: remove ARCH_SELECT_MEMORY_MODEL Mike Rapoport
2019-05-01 19:56 ` [PATCH 2/3] s390: " Mike Rapoport
@ 2019-05-01 19:56 ` Mike Rapoport
2019-05-16 5:19 ` [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
3 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2019-05-01 19:56 UTC (permalink / raw)
To: Andrew Morton
Cc: Arnd Bergmann, Christoph Hellwig, David S. Miller,
Heiko Carstens, Martin Schwidefsky, Russell King,
linux-arm-kernel, linux-s390, sparclinux, linux-arch, linux-mm,
linux-kernel, Mike Rapoport
The ARCH_SELECT_MEMORY_MODEL option is enabled only for 64-bit. However,
64-bit configuration also enables ARCH_SPARSEMEM_DEFAULT and there is no
ARCH_FLATMEM_ENABLE in arch/sparc/Kconfig.
With such settings, the dependencies in mm/Kconfig are always evaluated to
SPARSEMEM=y for 64-bit and to FLATMEM=y for 32-bit.
The ARCH_SELECT_MEMORY_MODEL option in arch/sparc/Kconfig does not affect
anything and can be removed.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/sparc/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 40f8f4f..9137dbe 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -305,9 +305,6 @@ config NODES_SPAN_OTHER_NODES
def_bool y
depends on NEED_MULTIPLE_NODES
-config ARCH_SELECT_MEMORY_MODEL
- def_bool y if SPARC64
-
config ARCH_SPARSEMEM_ENABLE
def_bool y if SPARC64
select SPARSEMEM_VMEMMAP_ENABLE
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect
2019-05-01 19:56 [PATCH 0/3] remove ARCH_SELECT_MEMORY_MODEL where it has no effect Mike Rapoport
` (2 preceding siblings ...)
2019-05-01 19:56 ` [PATCH 3/3] sparc: " Mike Rapoport
@ 2019-05-16 5:19 ` Mike Rapoport
3 siblings, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2019-05-16 5:19 UTC (permalink / raw)
To: Andrew Morton
Cc: Arnd Bergmann, Christoph Hellwig, David S. Miller,
Heiko Carstens, Martin Schwidefsky, Russell King,
linux-arm-kernel, linux-s390, sparclinux, linux-arch, linux-mm,
linux-kernel
Andrew,
Can this go via the -mm tree?
On Wed, May 01, 2019 at 10:56:14PM +0300, Mike Rapoport wrote:
> Hi,
>
> For several architectures the ARCH_SELECT_MEMORY_MODEL has no real effect
> because the dependencies for the memory model are always evaluated to a
> single value.
>
> Remove the ARCH_SELECT_MEMORY_MODEL from the Kconfigs for these
> architectures.
>
> Mike Rapoport (3):
> arm: remove ARCH_SELECT_MEMORY_MODEL
> s390: remove ARCH_SELECT_MEMORY_MODEL
> sparc: remove ARCH_SELECT_MEMORY_MODEL
>
> arch/arm/Kconfig | 3 ---
> arch/s390/Kconfig | 3 ---
> arch/sparc/Kconfig | 3 ---
> 3 files changed, 9 deletions(-)
>
> --
> 2.7.4
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread