* [PATCH] mm, oom: Remove redundant OOM score normalization at select_bad_process().
@ 2019-06-18 10:23 Tetsuo Handa
2019-06-19 5:35 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Tetsuo Handa @ 2019-06-18 10:23 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, Tetsuo Handa
Since commit bbbe48029720d2c6 ("mm, oom: remove 'prefer children over
parent' heuristic") removed
"%s: Kill process %d (%s) score %u or sacrifice child\n"
line, oc->chosen_points is no longer used after select_bad_process().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
mm/oom_kill.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 09a5116..789a1bc 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -380,8 +380,6 @@ static void select_bad_process(struct oom_control *oc)
break;
rcu_read_unlock();
}
-
- oc->chosen_points = oc->chosen_points * 1000 / oc->totalpages;
}
static int dump_task(struct task_struct *p, void *arg)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm, oom: Remove redundant OOM score normalization at select_bad_process().
2019-06-18 10:23 [PATCH] mm, oom: Remove redundant OOM score normalization at select_bad_process() Tetsuo Handa
@ 2019-06-19 5:35 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2019-06-19 5:35 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: Andrew Morton, linux-mm
On Tue 18-06-19 19:23:55, Tetsuo Handa wrote:
> Since commit bbbe48029720d2c6 ("mm, oom: remove 'prefer children over
> parent' heuristic") removed
>
> "%s: Kill process %d (%s) score %u or sacrifice child\n"
>
> line, oc->chosen_points is no longer used after select_bad_process().
Well spotted. I am still trying to understand how that was supposed to
work before that commit as oom_badness() already provides a normalized
value so we have normalized it for the second time. But that is largely
irrelevant for this patch.
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/oom_kill.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 09a5116..789a1bc 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -380,8 +380,6 @@ static void select_bad_process(struct oom_control *oc)
> break;
> rcu_read_unlock();
> }
> -
> - oc->chosen_points = oc->chosen_points * 1000 / oc->totalpages;
> }
>
> static int dump_task(struct task_struct *p, void *arg)
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 5:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 10:23 [PATCH] mm, oom: Remove redundant OOM score normalization at select_bad_process() Tetsuo Handa
2019-06-19 5:35 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).