* [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
@ 2019-11-18 3:26 zhong jiang
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: zhong jiang @ 2019-11-18 3:26 UTC (permalink / raw)
To: sashal, gregkh, stable, willy; +Cc: linux-mm, yangyingliang
The commit 391d4ee568b5 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 391d4ee568b5 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 5b2cc9f9b1f1..e55aa460a2c0 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2664,7 +2664,7 @@ static void shmem_tag_pins(struct address_space *mapping)
spin_lock_irq(&mapping->tree_lock);
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4.19] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
@ 2019-11-18 3:26 ` zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 5:00 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree gregkh
2019-11-18 3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: zhong jiang @ 2019-11-18 3:26 UTC (permalink / raw)
To: sashal, gregkh, stable, willy; +Cc: linux-mm, yangyingliang
The commit 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
mm/memfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memfd.c b/mm/memfd.c
index 5859705dafe1..9e68a4320a0e 100644
--- a/mm/memfd.c
+++ b/mm/memfd.c
@@ -41,7 +41,7 @@ static void memfd_tag_pins(struct address_space *mapping)
xa_lock_irq(&mapping->i_pages);
radix_tree_for_each_slot(slot, &mapping->i_pages, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->i_pages.xa_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
@ 2019-11-18 3:26 ` zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree gregkh
2019-11-18 3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
` (2 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: zhong jiang @ 2019-11-18 3:26 UTC (permalink / raw)
To: sashal, gregkh, stable, willy; +Cc: linux-mm, yangyingliang
The commit eb4058d8daf8 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: eb4058d8daf8 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 62668379623b..e40239bf6dfe 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1862,7 +1862,7 @@ static void shmem_tag_pins(struct address_space *mapping)
spin_lock_irq(&mapping->tree_lock);
restart:
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page))
goto restart;
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
2019-11-18 3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
@ 2019-11-18 3:26 ` zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree gregkh
2019-11-18 12:24 ` [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree gregkh
4 siblings, 2 replies; 12+ messages in thread
From: zhong jiang @ 2019-11-18 3:26 UTC (permalink / raw)
To: sashal, gregkh, stable, willy; +Cc: linux-mm, yangyingliang
The commit 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index ac8a5fedc245..6266a7d1ba00 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2464,7 +2464,7 @@ static void shmem_tag_pins(struct address_space *mapping)
spin_lock_irq(&mapping->tree_lock);
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
` (2 preceding siblings ...)
2019-11-18 3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
@ 2019-11-18 12:24 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree gregkh
4 siblings, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2019-11-18 12:24 UTC (permalink / raw)
To: zhong jiang; +Cc: sashal, gregkh, stable, linux-mm, yangyingliang
On Mon, Nov 18, 2019 at 11:26:07AM +0800, zhong jiang wrote:
> The commit 391d4ee568b5 ("memfd: Fix locking when tagging pins")
> introduces the following warning messages.
>
> *WARNING: suspicious RCU usage in memfd_wait_for_pins*
>
> It is because we still use radix_tree_deref_slot without read_rcu_lock.
> We should use radix_tree_deref_slot_protected instead in the case.
>
> Cc: stable@vger.kernel.org
> Fixes: 391d4ee568b5 ("memfd: Fix locking when tagging pins")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4.19] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
@ 2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 5:00 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree gregkh
1 sibling, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2019-11-18 12:25 UTC (permalink / raw)
To: zhong jiang; +Cc: sashal, gregkh, stable, linux-mm, yangyingliang
On Mon, Nov 18, 2019 at 11:26:08AM +0800, zhong jiang wrote:
> The commit 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
> introduces the following warning messages.
>
> *WARNING: suspicious RCU usage in memfd_wait_for_pins*
>
> It is because we still use radix_tree_deref_slot without read_rcu_lock.
> We should use radix_tree_deref_slot_protected instead in the case.
>
> Cc: stable@vger.kernel.org
> Fixes: 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
@ 2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree gregkh
1 sibling, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2019-11-18 12:25 UTC (permalink / raw)
To: zhong jiang; +Cc: sashal, gregkh, stable, linux-mm, yangyingliang
On Mon, Nov 18, 2019 at 11:26:09AM +0800, zhong jiang wrote:
> The commit eb4058d8daf8 ("memfd: Fix locking when tagging pins")
> introduces the following warning messages.
>
> *WARNING: suspicious RCU usage in memfd_wait_for_pins*
>
> It is because we still use radix_tree_deref_slot without read_rcu_lock.
> We should use radix_tree_deref_slot_protected instead in the case.
>
> Cc: stable@vger.kernel.org
> Fixes: eb4058d8daf8 ("memfd: Fix locking when tagging pins")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning.
2019-11-18 3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
@ 2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree gregkh
1 sibling, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2019-11-18 12:25 UTC (permalink / raw)
To: zhong jiang; +Cc: sashal, gregkh, stable, linux-mm, yangyingliang
On Mon, Nov 18, 2019 at 11:26:10AM +0800, zhong jiang wrote:
> The commit 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
> introduces the following warning messages.
>
> *WARNING: suspicious RCU usage in memfd_wait_for_pins*
>
> It is because we still use radix_tree_deref_slot without read_rcu_lock.
> We should use radix_tree_deref_slot_protected instead in the case.
>
> Cc: stable@vger.kernel.org
> Fixes: 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree
2019-11-18 3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
@ 2019-11-19 4:59 ` gregkh
1 sibling, 0 replies; 12+ messages in thread
From: gregkh @ 2019-11-19 4:59 UTC (permalink / raw)
To: gregkh, linux-mm, sashal, willy, yangyingliang, zhongjiang; +Cc: stable-commits
This is a note to let you know that I've just added the patch titled
memfd: Use radix_tree_deref_slot_protected to avoid the warning.
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From zhongjiang@huawei.com Tue Nov 19 05:57:26 2019
From: zhong jiang <zhongjiang@huawei.com>
Date: Mon, 18 Nov 2019 11:26:09 +0800
Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Message-ID: <20191118032610.182862-3-zhongjiang@huawei.com>
From: zhong jiang <zhongjiang@huawei.com>
The commit eb4058d8daf8 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: eb4058d8daf8 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1862,7 +1862,7 @@ static void shmem_tag_pins(struct addres
spin_lock_irq(&mapping->tree_lock);
restart:
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page))
goto restart;
Patches currently in stable-queue which might be from zhongjiang@huawei.com are
queue-4.4/misc-genwqe-should-return-proper-error-value.patch
queue-4.4/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
^ permalink raw reply [flat|nested] 12+ messages in thread
* Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree
2019-11-18 3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
@ 2019-11-19 4:59 ` gregkh
1 sibling, 0 replies; 12+ messages in thread
From: gregkh @ 2019-11-19 4:59 UTC (permalink / raw)
To: gregkh, linux-mm, sashal, willy, yangyingliang, zhongjiang; +Cc: stable-commits
This is a note to let you know that I've just added the patch titled
memfd: Use radix_tree_deref_slot_protected to avoid the warning.
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From zhongjiang@huawei.com Tue Nov 19 05:57:08 2019
From: zhong jiang <zhongjiang@huawei.com>
Date: Mon, 18 Nov 2019 11:26:10 +0800
Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Message-ID: <20191118032610.182862-4-zhongjiang@huawei.com>
From: zhong jiang <zhongjiang@huawei.com>
The commit 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 3ce6b467b9b2 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2464,7 +2464,7 @@ static void shmem_tag_pins(struct addres
spin_lock_irq(&mapping->tree_lock);
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
Patches currently in stable-queue which might be from zhongjiang@huawei.com are
queue-4.9/misc-genwqe-should-return-proper-error-value.patch
queue-4.9/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
^ permalink raw reply [flat|nested] 12+ messages in thread
* Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
` (3 preceding siblings ...)
2019-11-18 12:24 ` [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
@ 2019-11-19 4:59 ` gregkh
4 siblings, 0 replies; 12+ messages in thread
From: gregkh @ 2019-11-19 4:59 UTC (permalink / raw)
To: gregkh, linux-mm, sashal, willy, yangyingliang, zhongjiang; +Cc: stable-commits
This is a note to let you know that I've just added the patch titled
memfd: Use radix_tree_deref_slot_protected to avoid the warning.
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From zhongjiang@huawei.com Tue Nov 19 05:55:06 2019
From: zhong jiang <zhongjiang@huawei.com>
Date: Mon, 18 Nov 2019 11:26:07 +0800
Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Message-ID: <20191118032610.182862-1-zhongjiang@huawei.com>
From: zhong jiang <zhongjiang@huawei.com>
The commit 391d4ee568b5 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 391d4ee568b5 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2664,7 +2664,7 @@ static void shmem_tag_pins(struct addres
spin_lock_irq(&mapping->tree_lock);
radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
Patches currently in stable-queue which might be from zhongjiang@huawei.com are
queue-4.14/misc-genwqe-should-return-proper-error-value.patch
queue-4.14/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
^ permalink raw reply [flat|nested] 12+ messages in thread
* Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
@ 2019-11-19 5:00 ` gregkh
1 sibling, 0 replies; 12+ messages in thread
From: gregkh @ 2019-11-19 5:00 UTC (permalink / raw)
To: gregkh, linux-mm, sashal, willy, yangyingliang, zhongjiang; +Cc: stable-commits
This is a note to let you know that I've just added the patch titled
memfd: Use radix_tree_deref_slot_protected to avoid the warning.
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From zhongjiang@huawei.com Tue Nov 19 05:56:14 2019
From: zhong jiang <zhongjiang@huawei.com>
Date: Mon, 18 Nov 2019 11:26:08 +0800
Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
Message-ID: <20191118032610.182862-2-zhongjiang@huawei.com>
From: zhong jiang <zhongjiang@huawei.com>
The commit 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
introduces the following warning messages.
*WARNING: suspicious RCU usage in memfd_wait_for_pins*
It is because we still use radix_tree_deref_slot without read_rcu_lock.
We should use radix_tree_deref_slot_protected instead in the case.
Cc: stable@vger.kernel.org
Fixes: 99b45e7a1ba1 ("memfd: Fix locking when tagging pins")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/memfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/memfd.c
+++ b/mm/memfd.c
@@ -41,7 +41,7 @@ static void memfd_tag_pins(struct addres
xa_lock_irq(&mapping->i_pages);
radix_tree_for_each_slot(slot, &mapping->i_pages, &iter, start) {
- page = radix_tree_deref_slot(slot);
+ page = radix_tree_deref_slot_protected(slot, &mapping->i_pages.xa_lock);
if (!page || radix_tree_exception(page)) {
if (radix_tree_deref_retry(page)) {
slot = radix_tree_iter_retry(&iter);
Patches currently in stable-queue which might be from zhongjiang@huawei.com are
queue-4.19/misc-genwqe-should-return-proper-error-value.patch
queue-4.19/arm-at91-pm-call-put_device-instead-of-of_node_put-i.patch
queue-4.19/coresight-use-err_cast-instead-of-err_ptr.patch
queue-4.19/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-19 5:00 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 3:26 [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 3:26 ` [PATCH 4.19] " zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 5:00 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.19-stable tree gregkh
2019-11-18 3:26 ` [PATCH 4.4] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.4-stable tree gregkh
2019-11-18 3:26 ` [PATCH 4.9] memfd: Use radix_tree_deref_slot_protected to avoid the warning zhong jiang
2019-11-18 12:25 ` Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.9-stable tree gregkh
2019-11-18 12:24 ` [PATCH 4.14] memfd: Use radix_tree_deref_slot_protected to avoid the warning Matthew Wilcox
2019-11-19 4:59 ` Patch "memfd: Use radix_tree_deref_slot_protected to avoid the warning." has been added to the 4.14-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).