* [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics.
@ 2019-11-29 1:29 Chanho Min
2019-11-29 15:17 ` Vlastimil Babka
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chanho Min @ 2019-11-29 1:29 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton
Cc: linux-mm, linux-kernel, seungho1.park, Inkyu Hwang, Jinsuk Choi,
Chanho Min
When zspage is migrated to the other zone, the zone page state should
be updated as well.
Signed-off-by: Chanho Min <chanho.min@lge.com>
Signed-off-by: Jinsuk Choi <jjinsuk.choi@lge.com>
---
mm/zsmalloc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2b2b9aa..22d17ec 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2069,6 +2069,11 @@ static int zs_page_migrate(struct address_space *mapping, struct page *newpage,
zs_pool_dec_isolated(pool);
}
+ if (page_zone(newpage) != page_zone(page)) {
+ dec_zone_page_state(page, NR_ZSPAGES);
+ inc_zone_page_state(newpage, NR_ZSPAGES);
+ }
+
reset_page(page);
put_page(page);
page = newpage;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics.
2019-11-29 1:29 [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics Chanho Min
@ 2019-11-29 15:17 ` Vlastimil Babka
2019-12-02 0:55 ` 민찬호
2019-12-02 2:39 ` Sergey Senozhatsky
2019-12-04 1:23 ` Minchan Kim
2 siblings, 1 reply; 5+ messages in thread
From: Vlastimil Babka @ 2019-11-29 15:17 UTC (permalink / raw)
To: Chanho Min, Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton
Cc: linux-mm, linux-kernel, seungho1.park, Inkyu Hwang, Jinsuk Choi
On 11/29/19 2:29 AM, Chanho Min wrote:
> When zspage is migrated to the other zone, the zone page state should
> be updated as well.
What are the user visible effects? I assume NR_ZSPAGES accounting can go
wrong otherwise? Has it been observed in practice?
Should we Cc stable and identify a Fixes: commit?
Thanks,
Vlastimil
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> Signed-off-by: Jinsuk Choi <jjinsuk.choi@lge.com>
> ---
> mm/zsmalloc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 2b2b9aa..22d17ec 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2069,6 +2069,11 @@ static int zs_page_migrate(struct address_space *mapping, struct page *newpage,
> zs_pool_dec_isolated(pool);
> }
>
> + if (page_zone(newpage) != page_zone(page)) {
> + dec_zone_page_state(page, NR_ZSPAGES);
> + inc_zone_page_state(newpage, NR_ZSPAGES);
> + }
> +
> reset_page(page);
> put_page(page);
> page = newpage;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics.
2019-11-29 15:17 ` Vlastimil Babka
@ 2019-12-02 0:55 ` 민찬호
0 siblings, 0 replies; 5+ messages in thread
From: 민찬호 @ 2019-12-02 0:55 UTC (permalink / raw)
To: Vlastimil Babka
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton,
linux-mm, linux-kernel, 박승호,
황인규, 최진석,
stable
[-- Attachment #1: Type: text/html, Size: 1179 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics.
2019-11-29 1:29 [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics Chanho Min
2019-11-29 15:17 ` Vlastimil Babka
@ 2019-12-02 2:39 ` Sergey Senozhatsky
2019-12-04 1:23 ` Minchan Kim
2 siblings, 0 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2019-12-02 2:39 UTC (permalink / raw)
To: Chanho Min
Cc: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, Andrew Morton,
linux-mm, linux-kernel, seungho1.park, Inkyu Hwang, Jinsuk Choi
On (19/11/29 10:29), Chanho Min wrote:
> When zspage is migrated to the other zone, the zone page state should
> be updated as well.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> Signed-off-by: Jinsuk Choi <jjinsuk.choi@lge.com>
Looks good to me.
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics.
2019-11-29 1:29 [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics Chanho Min
2019-11-29 15:17 ` Vlastimil Babka
2019-12-02 2:39 ` Sergey Senozhatsky
@ 2019-12-04 1:23 ` Minchan Kim
2 siblings, 0 replies; 5+ messages in thread
From: Minchan Kim @ 2019-12-04 1:23 UTC (permalink / raw)
To: Chanho Min
Cc: Nitin Gupta, Sergey Senozhatsky, Andrew Morton, linux-mm,
linux-kernel, seungho1.park, Inkyu Hwang, Jinsuk Choi
On Fri, Nov 29, 2019 at 10:29:27AM +0900, Chanho Min wrote:
> When zspage is migrated to the other zone, the zone page state should
> be updated as well.
>
> Signed-off-by: Chanho Min <chanho.min@lge.com>
> Signed-off-by: Jinsuk Choi <jjinsuk.choi@lge.com>
Hi Chanho,
It seems your previous mail included fix and stable tag was mangled by
HTML mail. Could you resend the patch it unless Andrew pick up?
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-04 1:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 1:29 [PATCH] mm/zsmalloc.c: fix the migrated zspage statistics Chanho Min
2019-11-29 15:17 ` Vlastimil Babka
2019-12-02 0:55 ` 민찬호
2019-12-02 2:39 ` Sergey Senozhatsky
2019-12-04 1:23 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).