* [PATCH] mm/vmscan: remove unused RECLAIM_OFF/RECLAIM_ZONE
@ 2020-01-14 12:39 Alex Shi
2020-01-15 0:22 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2020-01-14 12:39 UTC (permalink / raw)
Cc: Andrew Morton, linux-mm, linux-kernel
commit 1b2ffb7896ad ("[PATCH] Zone reclaim: Allow modification of zone reclaim behavior")'
defined RECLAIM_OFF/RECLAIM_ZONE, but never use them, so better to remove them.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/vmscan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 572fb17c6273..4e699ed3501e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4126,8 +4126,6 @@ static int __init kswapd_init(void)
*/
int node_reclaim_mode __read_mostly;
-#define RECLAIM_OFF 0
-#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmscan: remove unused RECLAIM_OFF/RECLAIM_ZONE
2020-01-14 12:39 [PATCH] mm/vmscan: remove unused RECLAIM_OFF/RECLAIM_ZONE Alex Shi
@ 2020-01-15 0:22 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2020-01-15 0:22 UTC (permalink / raw)
To: Alex Shi; +Cc: linux-mm, linux-kernel
On Tue, 14 Jan 2020 20:39:33 +0800 Alex Shi <alex.shi@linux.alibaba.com> wrote:
> commit 1b2ffb7896ad ("[PATCH] Zone reclaim: Allow modification of zone reclaim behavior")'
> defined RECLAIM_OFF/RECLAIM_ZONE, but never use them, so better to remove them.
>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4126,8 +4126,6 @@ static int __init kswapd_init(void)
> */
> int node_reclaim_mode __read_mostly;
>
> -#define RECLAIM_OFF 0
> -#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
> #define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
> #define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
--- a/mm/vmscan.c~mm-vmscan-remove-unused-reclaim_off-reclaim_zone-fix
+++ a/mm/vmscan.c
@@ -4118,8 +4118,8 @@ module_init(kswapd_init)
*/
int node_reclaim_mode __read_mostly;
-#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
-#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
+#define RECLAIM_WRITE (1<<0) /* Writeout pages during reclaim */
+#define RECLAIM_UNMAP (1<<1) /* Unmap pages during reclaim */
/*
* Priority for NODE_RECLAIM. This determines the fraction of pages
_
This might be a bit picky ;)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 12:39 [PATCH] mm/vmscan: remove unused RECLAIM_OFF/RECLAIM_ZONE Alex Shi
2020-01-15 0:22 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).