* [PATCH] memblock tests: Fix testing with 32-bit physical addresses
@ 2022-03-04 12:52 Karolina Drobnik
2022-03-06 5:04 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Karolina Drobnik @ 2022-03-04 12:52 UTC (permalink / raw)
To: linux-mm; +Cc: rppt, linux-kernel, Karolina Drobnik
Building memblock simulator on x86_64 with 32BIT_PHYS_ADDR_T=1
produces "cast to pointer from integer of different size" warnings.
Fix them by building the binary in 32-bit environment when using
32-bit physical addresses.
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
---
This patch is on the top of memblock/for-next.
tools/testing/memblock/scripts/Makefile.include | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/memblock/scripts/Makefile.include b/tools/testing/memblock/scripts/Makefile.include
index 699b0d6cda07..393655310324 100644
--- a/tools/testing/memblock/scripts/Makefile.include
+++ b/tools/testing/memblock/scripts/Makefile.include
@@ -11,7 +11,9 @@ ifeq ($(MOVABLE_NODE), 1)
CFLAGS += -D MOVABLE_NODE
endif
-# Use 32 bit physical addresses
+# Use 32 bit physical addresses.
+# Remember to install 32-bit version of dependencies.
ifeq ($(32BIT_PHYS_ADDR_T), 1)
- CFLAGS += -U CONFIG_PHYS_ADDR_T_64BIT
+ CFLAGS += -m32 -U CONFIG_PHYS_ADDR_T_64BIT
+ LDFLAGS += -m32
endif
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memblock tests: Fix testing with 32-bit physical addresses
2022-03-04 12:52 [PATCH] memblock tests: Fix testing with 32-bit physical addresses Karolina Drobnik
@ 2022-03-06 5:04 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2022-03-06 5:04 UTC (permalink / raw)
To: Karolina Drobnik, linux-mm; +Cc: Mike Rapoport, linux-kernel, rppt
On Fri, 4 Mar 2022 13:52:49 +0100, Karolina Drobnik wrote:
> Building memblock simulator on x86_64 with 32BIT_PHYS_ADDR_T=1
> produces "cast to pointer from integer of different size" warnings.
> Fix them by building the binary in 32-bit environment when using
> 32-bit physical addresses.
>
>
Applied, thanks!
[1/1] memblock tests: Fix testing with 32-bit physical addresses
commit 2a7ceac9e58167fadc3496c5f694543d4bbe03ef
Best regards,
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-06 5:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 12:52 [PATCH] memblock tests: Fix testing with 32-bit physical addresses Karolina Drobnik
2022-03-06 5:04 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).