From: Will Deacon <will@kernel.org>
To: mike.kravetz@oracle.com, osalvador@suse.de, rientjes@google.com,
mark.rutland@arm.com, Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, james.morse@arm.com,
bodeddub@amazon.com, david@redhat.com, catalin.marinas@arm.com,
song.bao.hua@hisilicon.com
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
smuchun@gmail.com, linux-kernel@vger.kernel.org,
duanxiongchun@bytedance.com, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org, fam.zheng@bytedance.com
Subject: Re: [PATCH v2 RESEND 1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB
Date: Mon, 7 Mar 2022 22:03:36 +0000 [thread overview]
Message-ID: <164668935493.3276132.12110588269320094587.b4-ty@kernel.org> (raw)
In-Reply-To: <20220302084624.33340-1-songmuchun@bytedance.com>
On Wed, 2 Mar 2022 16:46:23 +0800, Muchun Song wrote:
> When a contiguous HugeTLB page is mapped, set_pte_at() will be called
> CONT_PTES/CONT_PMDS times. Therefore, __sync_icache_dcache() will
> flush cache multiple times if the page is executable (to ensure
> the I-D cache coherency). However, the first flushing cache already
> covers subsequent cache flush operations. So only flusing cache
> for the head page if it is a HugeTLB page to avoid redundant cache
> flushing. In the next patch, it is also depends on this change
> since the tail vmemmap pages of HugeTLB is mapped with read-only
> meanning only head page struct can be modified.
>
> [...]
Applied first patch only to arm64 (for-next/mm), thanks!
[1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB
https://git.kernel.org/arm64/c/cf5a501d985b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
next prev parent reply other threads:[~2022-03-07 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 8:46 [PATCH v2 RESEND 1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB Muchun Song
2022-03-02 8:46 ` [PATCH v2 RESEND 2/2] arm64: mm: hugetlb: add support for free vmemmap pages of HugeTLB Muchun Song
2022-03-02 12:31 ` [PATCH v2 RESEND 1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB Catalin Marinas
2022-03-07 22:03 ` Will Deacon [this message]
2022-03-03 11:20 Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164668935493.3276132.12110588269320094587.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bodeddub@amazon.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=james.morse@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=smuchun@gmail.com \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).