From: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] fork: Improve error message for corrupted page tables
Date: Mon, 05 Aug 2019 20:09:59 -0700 [thread overview]
Message-ID: <1c6a18dd63e6005045034ccc7b04390ab3c605e5.camel@intel.com> (raw)
In-Reply-To: <4236c0c5-9671-b9fe-b5eb-7d1908767905@suse.cz>
On Mon, 2019-08-05 at 15:28 +0200, Vlastimil Babka wrote:
> On 8/2/19 8:46 AM, Prakhya, Sai Praneeth wrote:
> > > > > > +static const char * const resident_page_types[NR_MM_COUNTERS] = {
> > > > > > + "MM_FILEPAGES",
> > > > > > + "MM_ANONPAGES",
> > > > > > + "MM_SWAPENTS",
> > > > > > + "MM_SHMEMPAGES",
> > > > > > +};
> > > > >
> > > > > But please let's not put this in a header file. We're asking the
> > > > > compiler to put a copy of all of this into every compilation unit
> > > > > which includes the header. Presumably the compiler is smart enough
> > > > > not to do that, but it's not good practice.
> > > >
> > > > Thanks for the explanation. Makes sense to me.
> > > >
> > > > Just wanted to check before sending V2, Is it OK if I add this to
> > > > kernel/fork.c? or do you have something else in mind?
> > >
> > > I was thinking somewhere like mm/util.c so the array could be used by
> > > other
> > > code. But it seems there is no such code. Perhaps it's best to just
> > > leave fork.c as
> > > it is now.
> >
> > Ok, so does that mean have the struct in header file itself?
>
> If the struct definition (including the string values) was in mm/util.c,
> there would have to be a declaration in a header. If it's in fork.c with
> the only users, there doesn't need to be separate declaration in a header.
Makes sense.
>
> > Sorry! for too many questions. I wanted to check with you before changing
> > because it's *the* fork.c file (I presume random changes will not be
> > encouraged here)
> >
> > I am not yet clear on what's the right thing to do here :(
> > So, could you please help me in deciding.
>
> fork.c should be fine, IMHO
I was leaning to add struct definition in fork.c as well but just wanted to
check with Andrew before posting V2.
Thanks for the reply though :)
Regards,
Sai
next prev parent reply other threads:[~2019-08-06 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 22:18 [PATCH] fork: Improve error message for corrupted page tables Sai Praneeth Prakhya
2019-07-31 22:27 ` Andrew Morton
2019-07-31 22:36 ` Sai Praneeth Prakhya
2019-08-01 4:20 ` Andrew Morton
2019-08-02 6:46 ` Prakhya, Sai Praneeth
2019-08-05 13:28 ` Vlastimil Babka
2019-08-06 3:09 ` Sai Praneeth Prakhya [this message]
2019-08-01 5:48 ` Anshuman Khandual
2019-08-02 6:52 ` Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c6a18dd63e6005045034ccc7b04390ab3c605e5.camel@intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).