From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [PATCH] fork: Improve error message for corrupted page tables
Date: Fri, 2 Aug 2019 06:52:10 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F4F9D62D6@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <56ad91b8-1ea0-6736-5bc5-eea0ced01054@arm.com>
> >
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Suggested-by/Acked-by: Dave Hansen <dave.hansen@intel.com>
>
> Though I am not sure, should the above be two separate lines instead ?
Sure! Will split them in V2.
>
> > Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> > ---
> > include/linux/mm_types_task.h | 7 +++++++
> > kernel/fork.c | 4 ++--
> > 2 files changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/mm_types_task.h
> > b/include/linux/mm_types_task.h index d7016dcb245e..881f4ea3a1b5
> > 100644
> > --- a/include/linux/mm_types_task.h
> > +++ b/include/linux/mm_types_task.h
> > @@ -44,6 +44,13 @@ enum {
> > NR_MM_COUNTERS
> > };
> >
> > +static const char * const resident_page_types[NR_MM_COUNTERS] = {
> > + "MM_FILEPAGES",
> > + "MM_ANONPAGES",
> > + "MM_SWAPENTS",
> > + "MM_SHMEMPAGES",
> > +};
>
> Should index them to match respective typo macros.
>
> [MM_FILEPAGES] = "MM_FILEPAGES",
> [MM_ANONPAGES] = "MM_ANONPAGES",
> [MM_SWAPENTS] = "MM_SWAPENTS",
> [MM_SHMEMPAGES] = "MM_SHMEMPAGES",
Sure! Will change it.
> > +
> > #if USE_SPLIT_PTE_PTLOCKS && defined(CONFIG_MMU) #define
> > SPLIT_RSS_COUNTING
> > /* per-thread cached information, */
> > diff --git a/kernel/fork.c b/kernel/fork.c index
> > 2852d0e76ea3..6aef5842d4e0 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -649,8 +649,8 @@ static void check_mm(struct mm_struct *mm)
> > long x = atomic_long_read(&mm->rss_stat.count[i]);
> >
> > if (unlikely(x))
> > - printk(KERN_ALERT "BUG: Bad rss-counter state "
> > - "mm:%p idx:%d val:%ld\n", mm, i, x);
> > + pr_alert("BUG: Bad rss-counter state mm:%p type:%s
> val:%ld\n",
> > + mm, resident_page_types[i], x);
> It changes the print function as well, though very minor change but perhaps
> mention that in the commit message ?
Sure! Will mention it in V2.
I have changed printk() to pr_alert() because the other message in check_mm() uses pr_alert().
Regards,
Sai
prev parent reply other threads:[~2019-08-02 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 22:18 [PATCH] fork: Improve error message for corrupted page tables Sai Praneeth Prakhya
2019-07-31 22:27 ` Andrew Morton
2019-07-31 22:36 ` Sai Praneeth Prakhya
2019-08-01 4:20 ` Andrew Morton
2019-08-02 6:46 ` Prakhya, Sai Praneeth
2019-08-05 13:28 ` Vlastimil Babka
2019-08-06 3:09 ` Sai Praneeth Prakhya
2019-08-01 5:48 ` Anshuman Khandual
2019-08-02 6:52 ` Prakhya, Sai Praneeth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F4F9D62D6@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).