From: Mike Kravetz <mike.kravetz@oracle.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
Muchun Song <songmuchun@bytedance.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
David Rientjes <rientjes@google.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 5/5] hugetlb: add hugetlb demote page support
Date: Wed, 6 Oct 2021 11:52:33 -0700 [thread overview]
Message-ID: <1e699922-59a6-dc14-6676-b44c1bdf1a6f@oracle.com> (raw)
In-Reply-To: <20211006084112.GA12288@linux>
On 10/6/21 1:41 AM, Oscar Salvador wrote:
> On Fri, Oct 01, 2021 at 10:52:10AM -0700, Mike Kravetz wrote:
>> Demote page functionality will split a huge page into a number of huge
>> pages of a smaller size. For example, on x86 a 1GB huge page can be
>> demoted into 512 2M huge pages. Demotion is done 'in place' by simply
>> splitting the huge page.
>>
>> Added '*_for_demote' wrappers for remove_hugetlb_page,
>> destroy_compound_gigantic_page and prep_compound_gigantic_page for use
>> by demote code.
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>> ---
>> mm/hugetlb.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++-----
>> 1 file changed, 74 insertions(+), 8 deletions(-)
>>
> ...
>> +static int demote_free_huge_page(struct hstate *h, struct page *page)
>> +{
>> + int i, nid = page_to_nid(page);
>> + struct hstate *target_hstate;
>> + int rc = 0;
>> +
>> + target_hstate = size_to_hstate(PAGE_SIZE << h->demote_order);
>> +
>> + remove_hugetlb_page_for_demote(h, page, false);
>> + spin_unlock_irq(&hugetlb_lock);
>> +
>> + rc = alloc_huge_page_vmemmap(h, page);
>> + if (rc) {
>> + /* Allocation of vmemmmap failed, we can not demote page */
>> + spin_lock_irq(&hugetlb_lock);
>> + set_page_refcounted(page);
>> + add_hugetlb_page(h, page, false);
>> + return rc;
>> + }
>
> Question: You keep the original error code returned from alloc_huge_page_vmemmap()
> here, but then you lose it on demote_pool_huge_page() when doing the
> !demote_free_huge_page. Would not make more sense to keep it all the way down to
> demote_store() in case you want to return the actual error code?
>
Yes, I will return it all the way to demote_store (and the user).
>> +
>> + /*
>> + * Use destroy_compound_gigantic_page_for_demote for all huge page
>> + * sizes as it will not ref count pages.
>> + */
>> + destroy_compound_gigantic_page_for_demote(page, huge_page_order(h));
>
> It seems that for now we only allow gigantic pages to be demoted, but
> destroy_compound_gigantic_page_for_demote feels kind of wrong, even
> if it is only a wrapper that ends up calling _*gigantic_ functions.
>
> We want a routine that destroy a hugetlb to be demoted into smaller hugetlb
> pages, so the name gigantic makes little sense to appear in my opinion.
>
Agree, I do not love the name. Since it is only a wrapper, how about
destroy_hugetlb_page_for_demote? And, change those other *_for_demote
wrappers to similiarly not have gigantic in their names.
>> static int demote_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
>> __must_hold(&hugetlb_lock)
>> {
>> + int nr_nodes, node;
>> + struct page *page;
>> int rc = 0;
>>
>> lockdep_assert_held(&hugetlb_lock);
>> @@ -3313,9 +3377,15 @@ static int demote_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
>> if (!h->demote_order)
>> return rc;
>>
>> - /*
>> - * TODO - demote fucntionality will be added in subsequent patch
>> - */
>> + for_each_node_mask_to_free(h, nr_nodes, node, nodes_allowed) {
>> + if (!list_empty(&h->hugepage_freelists[node])) {
>> + page = list_entry(h->hugepage_freelists[node].next,
>> + struct page, lru);
>> + rc = !demote_free_huge_page(h, page);
>
> I kinda dislike this as I pointed out.
>
Will change.
Thanks for all your comments!
--
Mike Kravetz
next prev parent reply other threads:[~2021-10-06 18:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:52 [PATCH v3 0/5] hugetlb: add demote/split page functionality Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 1/5] hugetlb: add demote hugetlb page sysfs interfaces Mike Kravetz
2021-10-04 13:00 ` Oscar Salvador
2021-10-04 18:27 ` Mike Kravetz
2021-10-05 8:23 ` Oscar Salvador
2021-10-05 16:58 ` Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 2/5] mm/cma: add cma_pages_valid to determine if pages are in CMA Mike Kravetz
2021-10-05 8:45 ` Oscar Salvador
2021-10-05 17:06 ` Mike Kravetz
2021-10-05 8:48 ` David Hildenbrand
2021-10-01 17:52 ` [PATCH v3 3/5] hugetlb: be sure to free demoted CMA pages to CMA Mike Kravetz
2021-10-05 9:33 ` Oscar Salvador
2021-10-05 18:57 ` Mike Kravetz
2021-10-06 7:54 ` Oscar Salvador
2021-10-06 18:27 ` Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 4/5] hugetlb: add demote bool to gigantic page routines Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 5/5] hugetlb: add hugetlb demote page support Mike Kravetz
2021-10-06 8:41 ` Oscar Salvador
2021-10-06 18:52 ` Mike Kravetz [this message]
2021-10-07 7:52 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e699922-59a6-dc14-6676-b44c1bdf1a6f@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).