From: Mike Kravetz <mike.kravetz@oracle.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
Muchun Song <songmuchun@bytedance.com>,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
David Rientjes <rientjes@google.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 2/5] mm/cma: add cma_pages_valid to determine if pages are in CMA
Date: Tue, 5 Oct 2021 10:06:24 -0700 [thread overview]
Message-ID: <c01d3e08-aa53-f62e-1979-3d8a14414f0d@oracle.com> (raw)
In-Reply-To: <20211005084557.GB20412@linux>
On 10/5/21 1:45 AM, Oscar Salvador wrote:
> On Fri, Oct 01, 2021 at 10:52:07AM -0700, Mike Kravetz wrote:
>> +bool cma_pages_valid(struct cma *cma, const struct page *pages,
>> + unsigned long count)
>> +{
>> + unsigned long pfn;
>> +
>> + if (!cma || !pages)
>> + return false;
>> +
>> + pfn = page_to_pfn(pages);
>> +
>> + if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count)
>> + return false;
>> +
>> + return true;
>> +}
>> +
>> /**
>> * cma_release() - release allocated pages
>> * @cma: Contiguous memory region for which the allocation is performed.
>> @@ -539,16 +555,13 @@ bool cma_release(struct cma *cma, const struct page *pages,
>> {
>> unsigned long pfn;
>>
>> - if (!cma || !pages)
>> + if (!cma_pages_valid(cma, pages, count))
>> return false;
>>
>> pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count);
>>
>> pfn = page_to_pfn(pages);
>>
>> - if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count)
>> - return false;
>> -
>
> After this patch, the timing of printing the debug statement changes as we back
> off earlier.
> You might want to point that out in the changelog in case someone wonders why.
>
When making this change, I did not want to duplicate that debug
statement. However, duplicated code only becomes an issue if
CONFIG_DEBUG. So, duplication should be acceptable.
I will make the debug statements function as before.
--
Mike Kravetz
next prev parent reply other threads:[~2021-10-05 17:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 17:52 [PATCH v3 0/5] hugetlb: add demote/split page functionality Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 1/5] hugetlb: add demote hugetlb page sysfs interfaces Mike Kravetz
2021-10-04 13:00 ` Oscar Salvador
2021-10-04 18:27 ` Mike Kravetz
2021-10-05 8:23 ` Oscar Salvador
2021-10-05 16:58 ` Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 2/5] mm/cma: add cma_pages_valid to determine if pages are in CMA Mike Kravetz
2021-10-05 8:45 ` Oscar Salvador
2021-10-05 17:06 ` Mike Kravetz [this message]
2021-10-05 8:48 ` David Hildenbrand
2021-10-01 17:52 ` [PATCH v3 3/5] hugetlb: be sure to free demoted CMA pages to CMA Mike Kravetz
2021-10-05 9:33 ` Oscar Salvador
2021-10-05 18:57 ` Mike Kravetz
2021-10-06 7:54 ` Oscar Salvador
2021-10-06 18:27 ` Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 4/5] hugetlb: add demote bool to gigantic page routines Mike Kravetz
2021-10-01 17:52 ` [PATCH v3 5/5] hugetlb: add hugetlb demote page support Mike Kravetz
2021-10-06 8:41 ` Oscar Salvador
2021-10-06 18:52 ` Mike Kravetz
2021-10-07 7:52 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c01d3e08-aa53-f62e-1979-3d8a14414f0d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).