From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Ganesh Mahendran <opensource.ganesh@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Seth Jennings <sjenning@redhat.com>, Yu Zhao <yuzhao@google.com>,
Linux-MM <linux-mm@kvack.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info
Date: Fri, 20 May 2016 13:08:36 +0900 [thread overview]
Message-ID: <20160520040836.GA573@swordfish> (raw)
In-Reply-To: <1463671123-5479-1-git-send-email-ddstreet@ieee.org>
On (05/19/16 11:18), Dan Streetman wrote:
[..]
> zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
> if (!zs_stat_root)
> - return -ENOMEM;
> -
> - return 0;
> + pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
> }
>
> static void __exit zs_stat_exit(void)
> @@ -573,17 +575,19 @@ static const struct file_operations zs_stat_size_ops = {
> .release = single_release,
> };
>
> -static int zs_pool_stat_create(struct zs_pool *pool, const char *name)
> +static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
> {
> struct dentry *entry;
>
> - if (!zs_stat_root)
> - return -ENODEV;
> + if (!zs_stat_root) {
> + pr_warn("no root stat dir, not creating <%s> stat dir\n", name);
> + return;
> + }
just a small nit, there are basically two warn messages now for
`!zs_stat_root':
debugfs 'zsmalloc' stat dir creation failed
no root stat dir, not creating <%s> stat dir
may be we need only one of them; but no strong opinions.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-20 4:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 15:36 [PATCH] mm/zsmalloc: don't fail if can't create debugfs info Dan Streetman
2016-04-28 22:07 ` Andrew Morton
2016-04-29 0:38 ` Sergey Senozhatsky
2016-04-29 5:37 ` Minchan Kim
2016-04-29 14:50 ` Dan Streetman
2016-04-29 15:33 ` Minchan Kim
2016-05-03 2:18 ` Ganesh Mahendran
2016-05-19 15:18 ` [PATCHv2] " Dan Streetman
2016-05-20 2:33 ` Ganesh Mahendran
2016-05-20 4:08 ` Sergey Senozhatsky [this message]
2016-05-20 10:32 ` Dan Streetman
2016-05-23 3:03 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520040836.GA573@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.streetman@canonical.com \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=opensource.ganesh@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sjenning@redhat.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).