* [PATCH] mm: fix build warnings in <linux/compaction.h>
@ 2016-06-09 17:06 Randy Dunlap
2016-06-09 22:27 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2016-06-09 17:06 UTC (permalink / raw)
To: Linux MM, linux-next, Andrew Morton; +Cc: Stephen Rothwell
From: Randy Dunlap <rdunlap@infradead.org>
Fix build warnings when struct node is not defined:
In file included from ../include/linux/balloon_compaction.h:48:0,
from ../mm/balloon_compaction.c:11:
../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default]
static inline int compaction_register_node(struct node *node)
../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default]
static inline void compaction_unregister_node(struct node *node)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
include/linux/compaction.h | 1 +
1 file changed, 1 insertion(+)
Found in linux-next but also applies to mainline.
--- linux-next-20160609.orig/include/linux/compaction.h
+++ linux-next-20160609/include/linux/compaction.h
@@ -233,6 +233,7 @@ extern int compaction_register_node(stru
extern void compaction_unregister_node(struct node *node);
#else
+struct node;
static inline int compaction_register_node(struct node *node)
{
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mm: fix build warnings in <linux/compaction.h> 2016-06-09 17:06 [PATCH] mm: fix build warnings in <linux/compaction.h> Randy Dunlap @ 2016-06-09 22:27 ` Andrew Morton 2016-06-09 23:31 ` Minchan Kim 0 siblings, 1 reply; 6+ messages in thread From: Andrew Morton @ 2016-06-09 22:27 UTC (permalink / raw) To: Randy Dunlap; +Cc: Linux MM, linux-next, Stephen Rothwell, Minchan Kim On Thu, 9 Jun 2016 10:06:01 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build warnings when struct node is not defined: > > In file included from ../include/linux/balloon_compaction.h:48:0, > from ../mm/balloon_compaction.c:11: > ../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default] > static inline int compaction_register_node(struct node *node) > ../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > ../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default] > static inline void compaction_unregister_node(struct node *node) > > ... > > --- linux-next-20160609.orig/include/linux/compaction.h > +++ linux-next-20160609/include/linux/compaction.h > @@ -233,6 +233,7 @@ extern int compaction_register_node(stru > extern void compaction_unregister_node(struct node *node); > > #else > +struct node; > > static inline int compaction_register_node(struct node *node) > { Well compaction.h has no #includes at all and obviously depends on its including file(s) to bring in the definitions which it needs. So if we want to keep that (odd) model then we should fix mm-balloon-use-general-non-lru-movable-page-feature.patch thusly: From: Andrew Morton <akpm@linux-foundation.org> Subject: mm-balloon-use-general-non-lru-movable-page-feature-fix compaction.h requires that the includer first include node.h Reported-by: Randy Dunlap <rdunlap@infradead.org> Cc: Gioh Kim <gi-oh.kim@profitbricks.com> Cc: Konstantin Khlebnikov <koct9i@gmail.com> Cc: Minchan Kim <minchan@kernel.org> Cc: Rafael Aquini <aquini@redhat.com> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- a/include/linux/balloon_compaction.h~mm-balloon-use-general-non-lru-movable-page-feature-fix +++ a/include/linux/balloon_compaction.h @@ -45,6 +45,7 @@ #define _LINUX_BALLOON_COMPACTION_H #include <linux/pagemap.h> #include <linux/page-flags.h> +#include <linux/node.h> #include <linux/compaction.h> #include <linux/gfp.h> #include <linux/err.h> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix build warnings in <linux/compaction.h> 2016-06-09 22:27 ` Andrew Morton @ 2016-06-09 23:31 ` Minchan Kim 2016-06-09 23:37 ` Andrew Morton 0 siblings, 1 reply; 6+ messages in thread From: Minchan Kim @ 2016-06-09 23:31 UTC (permalink / raw) To: Andrew Morton; +Cc: Randy Dunlap, Linux MM, linux-next, Stephen Rothwell Hi Andrew, On Thu, Jun 09, 2016 at 03:27:16PM -0700, Andrew Morton wrote: > On Thu, 9 Jun 2016 10:06:01 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > > From: Randy Dunlap <rdunlap@infradead.org> > > > > Fix build warnings when struct node is not defined: > > > > In file included from ../include/linux/balloon_compaction.h:48:0, > > from ../mm/balloon_compaction.c:11: > > ../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default] > > static inline int compaction_register_node(struct node *node) > > ../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > ../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default] > > static inline void compaction_unregister_node(struct node *node) > > > > ... > > > > --- linux-next-20160609.orig/include/linux/compaction.h > > +++ linux-next-20160609/include/linux/compaction.h > > @@ -233,6 +233,7 @@ extern int compaction_register_node(stru > > extern void compaction_unregister_node(struct node *node); > > > > #else > > +struct node; > > > > static inline int compaction_register_node(struct node *node) > > { > > Well compaction.h has no #includes at all and obviously depends on its > including file(s) to bring in the definitions which it needs. > > So if we want to keep that (odd) model then we should fix > mm-balloon-use-general-non-lru-movable-page-feature.patch thusly: How about fixing such odd model in this chance? Otherwise, every non-lru page migration driver should include both compaction.h and node.h which is weired to me. :( I think there are two ways. 1. compaction.h include node.h directly so user of compaction.h don't need to take care about node.h 2. Randy's fix I looked up who use compaction_[un]register_node and found it's used only drivers/base/node.c which already include node.h so no problem. 1) I believe it's rare those functions to be needed by other files. 2) Those functions works if CONFIG_NUMA as well as CONFIG_COMPACTION which is rare configuration for many not-server system. So, I prefer Randy's fix. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix build warnings in <linux/compaction.h> 2016-06-09 23:31 ` Minchan Kim @ 2016-06-09 23:37 ` Andrew Morton 2016-06-09 23:51 ` Minchan Kim 0 siblings, 1 reply; 6+ messages in thread From: Andrew Morton @ 2016-06-09 23:37 UTC (permalink / raw) To: Minchan Kim; +Cc: Randy Dunlap, Linux MM, linux-next, Stephen Rothwell On Fri, 10 Jun 2016 08:31:43 +0900 Minchan Kim <minchan@kernel.org> wrote: > Hi Andrew, > > On Thu, Jun 09, 2016 at 03:27:16PM -0700, Andrew Morton wrote: > > On Thu, 9 Jun 2016 10:06:01 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > > > > From: Randy Dunlap <rdunlap@infradead.org> > > > > > > Fix build warnings when struct node is not defined: > > > > > > In file included from ../include/linux/balloon_compaction.h:48:0, > > > from ../mm/balloon_compaction.c:11: > > > ../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default] > > > static inline int compaction_register_node(struct node *node) > > > ../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > > ../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default] > > > static inline void compaction_unregister_node(struct node *node) > > > > > > ... > > > > > > --- linux-next-20160609.orig/include/linux/compaction.h > > > +++ linux-next-20160609/include/linux/compaction.h > > > @@ -233,6 +233,7 @@ extern int compaction_register_node(stru > > > extern void compaction_unregister_node(struct node *node); > > > > > > #else > > > +struct node; > > > > > > static inline int compaction_register_node(struct node *node) > > > { > > > > Well compaction.h has no #includes at all and obviously depends on its > > including file(s) to bring in the definitions which it needs. > > > > So if we want to keep that (odd) model then we should fix > > mm-balloon-use-general-non-lru-movable-page-feature.patch thusly: > > How about fixing such odd model in this chance? > Otherwise, every non-lru page migration driver should include > both compaction.h and node.h which is weired to me. :( > > I think there are two ways. > > 1. compaction.h include node.h directly so user of compaction.h don't > need to take care about node.h > > 2. Randy's fix > > I looked up who use compaction_[un]register_node and found it's used > only drivers/base/node.c which already include node.h so no problem. > > 1) I believe it's rare those functions to be needed by other files. > 2) Those functions works if CONFIG_NUMA as well as CONFIG_COMPACTION > which is rare configuration for many not-server system. If we're going to convert compaction.h to be standalone then it will need to include a whole bunch of things - what's special about node.h? > So, I prefer Randy's fix. Doesn't matter much. But note that Randy's patch declared struct node at line 233. It should be sone at approximatley line 1, to prevent future duplicated declarations. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix build warnings in <linux/compaction.h> 2016-06-09 23:37 ` Andrew Morton @ 2016-06-09 23:51 ` Minchan Kim 2016-06-10 0:33 ` Minchan Kim 0 siblings, 1 reply; 6+ messages in thread From: Minchan Kim @ 2016-06-09 23:51 UTC (permalink / raw) To: Andrew Morton; +Cc: Randy Dunlap, Linux MM, linux-next, Stephen Rothwell On Thu, Jun 09, 2016 at 04:37:19PM -0700, Andrew Morton wrote: > On Fri, 10 Jun 2016 08:31:43 +0900 Minchan Kim <minchan@kernel.org> wrote: > > > Hi Andrew, > > > > On Thu, Jun 09, 2016 at 03:27:16PM -0700, Andrew Morton wrote: > > > On Thu, 9 Jun 2016 10:06:01 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > > > > > > From: Randy Dunlap <rdunlap@infradead.org> > > > > > > > > Fix build warnings when struct node is not defined: > > > > > > > > In file included from ../include/linux/balloon_compaction.h:48:0, > > > > from ../mm/balloon_compaction.c:11: > > > > ../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default] > > > > static inline int compaction_register_node(struct node *node) > > > > ../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > > > ../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default] > > > > static inline void compaction_unregister_node(struct node *node) > > > > > > > > ... > > > > > > > > --- linux-next-20160609.orig/include/linux/compaction.h > > > > +++ linux-next-20160609/include/linux/compaction.h > > > > @@ -233,6 +233,7 @@ extern int compaction_register_node(stru > > > > extern void compaction_unregister_node(struct node *node); > > > > > > > > #else > > > > +struct node; > > > > > > > > static inline int compaction_register_node(struct node *node) > > > > { > > > > > > Well compaction.h has no #includes at all and obviously depends on its > > > including file(s) to bring in the definitions which it needs. > > > > > > So if we want to keep that (odd) model then we should fix > > > mm-balloon-use-general-non-lru-movable-page-feature.patch thusly: > > > > How about fixing such odd model in this chance? > > Otherwise, every non-lru page migration driver should include > > both compaction.h and node.h which is weired to me. :( > > > > I think there are two ways. > > > > 1. compaction.h include node.h directly so user of compaction.h don't > > need to take care about node.h > > > > 2. Randy's fix > > > > I looked up who use compaction_[un]register_node and found it's used > > only drivers/base/node.c which already include node.h so no problem. > > > > 1) I believe it's rare those functions to be needed by other files. > > 2) Those functions works if CONFIG_NUMA as well as CONFIG_COMPACTION > > which is rare configuration for many not-server system. > > If we're going to convert compaction.h to be standalone then it will > need to include a whole bunch of things - what's special about node.h? Fair enough. I realize it would be better to relocate non-lru page migration functions to new separate header but I don't have an good idea to name that file. :( Anyway, I will work for it. > > > So, I prefer Randy's fix. > > Doesn't matter much. But note that Randy's patch declared struct node > at line 233. It should be sone at approximatley line 1, to prevent > future duplicated declarations. with removing 218 forward declaration 'struct node;' by me. ;( I'm okay either approach until I fix the problem by introducing new header for non-lru page migration. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: fix build warnings in <linux/compaction.h> 2016-06-09 23:51 ` Minchan Kim @ 2016-06-10 0:33 ` Minchan Kim 0 siblings, 0 replies; 6+ messages in thread From: Minchan Kim @ 2016-06-10 0:33 UTC (permalink / raw) To: Andrew Morton Cc: Randy Dunlap, Linux MM, linux-next, Stephen Rothwell, Gioh Kim, Konstantin Khlebnikov, Rafael Aquini, Vlastimil Babka On Fri, Jun 10, 2016 at 08:51:41AM +0900, Minchan Kim wrote: > On Thu, Jun 09, 2016 at 04:37:19PM -0700, Andrew Morton wrote: > > On Fri, 10 Jun 2016 08:31:43 +0900 Minchan Kim <minchan@kernel.org> wrote: > > > > > Hi Andrew, > > > > > > On Thu, Jun 09, 2016 at 03:27:16PM -0700, Andrew Morton wrote: > > > > On Thu, 9 Jun 2016 10:06:01 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > > > > > > > > > From: Randy Dunlap <rdunlap@infradead.org> > > > > > > > > > > Fix build warnings when struct node is not defined: > > > > > > > > > > In file included from ../include/linux/balloon_compaction.h:48:0, > > > > > from ../mm/balloon_compaction.c:11: > > > > > ../include/linux/compaction.h:237:51: warning: 'struct node' declared inside parameter list [enabled by default] > > > > > static inline int compaction_register_node(struct node *node) > > > > > ../include/linux/compaction.h:237:51: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > > > > ../include/linux/compaction.h:242:54: warning: 'struct node' declared inside parameter list [enabled by default] > > > > > static inline void compaction_unregister_node(struct node *node) > > > > > > > > > > ... > > > > > > > > > > --- linux-next-20160609.orig/include/linux/compaction.h > > > > > +++ linux-next-20160609/include/linux/compaction.h > > > > > @@ -233,6 +233,7 @@ extern int compaction_register_node(stru > > > > > extern void compaction_unregister_node(struct node *node); > > > > > > > > > > #else > > > > > +struct node; > > > > > > > > > > static inline int compaction_register_node(struct node *node) > > > > > { > > > > > > > > Well compaction.h has no #includes at all and obviously depends on its > > > > including file(s) to bring in the definitions which it needs. > > > > > > > > So if we want to keep that (odd) model then we should fix > > > > mm-balloon-use-general-non-lru-movable-page-feature.patch thusly: > > > > > > How about fixing such odd model in this chance? > > > Otherwise, every non-lru page migration driver should include > > > both compaction.h and node.h which is weired to me. :( > > > > > > I think there are two ways. > > > > > > 1. compaction.h include node.h directly so user of compaction.h don't > > > need to take care about node.h > > > > > > 2. Randy's fix > > > > > > I looked up who use compaction_[un]register_node and found it's used > > > only drivers/base/node.c which already include node.h so no problem. > > > > > > 1) I believe it's rare those functions to be needed by other files. > > > 2) Those functions works if CONFIG_NUMA as well as CONFIG_COMPACTION > > > which is rare configuration for many not-server system. > > > > If we're going to convert compaction.h to be standalone then it will > > need to include a whole bunch of things - what's special about node.h? > > Fair enough. > I realize it would be better to relocate non-lru page migration functions to > new separate header but I don't have an good idea to name that file. :( > Anyway, I will work for it. > Andrew, it's quick fix. How about this? ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-10 0:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-06-09 17:06 [PATCH] mm: fix build warnings in <linux/compaction.h> Randy Dunlap 2016-06-09 22:27 ` Andrew Morton 2016-06-09 23:31 ` Minchan Kim 2016-06-09 23:37 ` Andrew Morton 2016-06-09 23:51 ` Minchan Kim 2016-06-10 0:33 ` Minchan Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).