linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 9661/9894] arch/x86/xen/enlighten.c:1328:2: note: in expansion of macro 'if'
@ 2016-07-14 11:39 kbuild test robot
  2016-07-14 20:02 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2016-07-14 11:39 UTC (permalink / raw)
  Cc: kbuild-all, Petr Tesarik, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   fd8d43a58dacbbde8beaaecbeaed7bd8bdbe6859
commit: 01eff0378a46a33a1252f9a3a4817263e16f52c0 [9661/9894] kexec: allow kdump with crash_kexec_post_notifiers
config: x86_64-randconfig-i0-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout 01eff0378a46a33a1252f9a3a4817263e16f52c0
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:12:0,
                    from include/linux/device.h:16,
                    from include/linux/node.h:17,
                    from include/linux/cpu.h:16,
                    from arch/x86/xen/enlighten.c:14:
   arch/x86/xen/enlighten.c: In function 'xen_panic_event':
   arch/x86/xen/enlighten.c:1328:7: error: implicit declaration of function 'kexec_crash_loaded' [-Werror=implicit-function-declaration]
     if (!kexec_crash_loaded())
          ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> arch/x86/xen/enlighten.c:1328:2: note: in expansion of macro 'if'
     if (!kexec_crash_loaded())
     ^~
   cc1: some warnings being treated as errors

vim +/if +1328 arch/x86/xen/enlighten.c

  1312	
  1313	static void xen_machine_power_off(void)
  1314	{
  1315		if (pm_power_off)
  1316			pm_power_off();
  1317		xen_reboot(SHUTDOWN_poweroff);
  1318	}
  1319	
  1320	static void xen_crash_shutdown(struct pt_regs *regs)
  1321	{
  1322		xen_reboot(SHUTDOWN_crash);
  1323	}
  1324	
  1325	static int
  1326	xen_panic_event(struct notifier_block *this, unsigned long event, void *ptr)
  1327	{
> 1328		if (!kexec_crash_loaded())
  1329			xen_reboot(SHUTDOWN_crash);
  1330		return NOTIFY_DONE;
  1331	}
  1332	
  1333	static struct notifier_block xen_panic_block = {
  1334		.notifier_call= xen_panic_event,
  1335		.priority = INT_MIN
  1336	};

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 25094 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-next:master 9661/9894] arch/x86/xen/enlighten.c:1328:2: note: in expansion of macro 'if'
  2016-07-14 11:39 [linux-next:master 9661/9894] arch/x86/xen/enlighten.c:1328:2: note: in expansion of macro 'if' kbuild test robot
@ 2016-07-14 20:02 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2016-07-14 20:02 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, Petr Tesarik, Linux Memory Management List

On Thu, 14 Jul 2016 19:39:43 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   fd8d43a58dacbbde8beaaecbeaed7bd8bdbe6859
> commit: 01eff0378a46a33a1252f9a3a4817263e16f52c0 [9661/9894] kexec: allow kdump with crash_kexec_post_notifiers
> config: x86_64-randconfig-i0-201628 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         git checkout 01eff0378a46a33a1252f9a3a4817263e16f52c0
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/ioport.h:12:0,
>                     from include/linux/device.h:16,
>                     from include/linux/node.h:17,
>                     from include/linux/cpu.h:16,
>                     from arch/x86/xen/enlighten.c:14:
>    arch/x86/xen/enlighten.c: In function 'xen_panic_event':
>    arch/x86/xen/enlighten.c:1328:7: error: implicit declaration of function 'kexec_crash_loaded' [-Werror=implicit-function-declaration]
>      if (!kexec_crash_loaded())

--- a/arch/x86/xen/enlighten.c~allow-kdump-with-crash_kexec_post_notifiers-fix
+++ a/arch/x86/xen/enlighten.c
@@ -34,9 +34,7 @@
 #include <linux/edd.h>
 #include <linux/frame.h>
 
-#ifdef CONFIG_KEXEC_CORE
 #include <linux/kexec.h>
-#endif
 
 #include <xen/xen.h>
 #include <xen/events.h>
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-14 20:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-14 11:39 [linux-next:master 9661/9894] arch/x86/xen/enlighten.c:1328:2: note: in expansion of macro 'if' kbuild test robot
2016-07-14 20:02 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).