From: Grygorii Maistrenko <grygoriimkd@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] slub: do not merge cache if slub_debug contains a never-merge flag
Date: Fri, 23 Dec 2016 20:00:23 +0100 [thread overview]
Message-ID: <20161223190023.GA9644@lp-laptop-d> (raw)
In-Reply-To: <alpine.DEB.2.20.1612231228340.21172@east.gentwo.org>
On Fri, Dec 23, 2016 at 12:30:02PM -0600, Christoph Lameter wrote:
>
> On Fri, 23 Dec 2016, Grygorii Maistrenko wrote:
>
> > In case CONFIG_SLUB_DEBUG_ON=n find_mergeable() gets debug features
> > from commandline but never checks if there are features from the
> > SLAB_NEVER_MERGE set.
> > As a result selected by slub_debug caches are always mergeable if they
> > have been created without a custom constructor set or without one of the
> > SLAB_* debug features on.
>
> WTF is this nonsense? That check is done a few lines earlier!
>
> struct kmem_cache *ind_mergeable(size_t size, size_t align,
> unsigned long flags, const char *name, void (*ctor)(void *))
> {
> struct kmem_cache *s;
>
> if (slab_nomerge || (flags & SLAB_NEVER_MERGE)) <----- !!!!!!
> return NULL;
This one check is done on flags passed to kmem_cache_create().
>
> if (ctor)
> return NULL;
>
> size = ALIGN(size, sizeof(void *));
> align = calculate_alignment(flags,
flags = kmem_cache_flags(size, flags, name, NULL);
I added here the missing line. This updates flags from commandline and
after this we do not check it.
>
>
> >
> > This adds the necessary check and makes selected slab caches unmergeable
> > if one of the SLAB_NEVER_MERGE features is set from commandline.
> >
> > Signed-off-by: Grygorii Maistrenko <grygoriimkd@gmail.com>
> > ---
> > mm/slab_common.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/mm/slab_common.c b/mm/slab_common.c
> > index 329b03843863..7341cba8c58b 100644
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -266,6 +266,9 @@ struct kmem_cache *find_mergeable(size_t size, size_t align,
> > size = ALIGN(size, align);
> > flags = kmem_cache_flags(size, flags, name, NULL);
> >
> > + if (flags & SLAB_NEVER_MERGE)
> > + return NULL;
> > +
> > list_for_each_entry_reverse(s, &slab_caches, list) {
> > if (slab_unmergeable(s))
> > continue;
> >
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-23 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 23:59 [PATCH] slub: do not merge cache if slub_debug contains a never-merge flag Grygorii Maistrenko
2016-12-23 18:30 ` Christoph Lameter
2016-12-23 19:00 ` Grygorii Maistrenko [this message]
2016-12-24 23:09 ` Christoph Lameter
2016-12-26 19:08 ` [PATCH v2] " Grygorii Maistrenko
2016-12-27 9:50 ` Pekka Enberg
2016-12-28 0:17 ` David Rientjes
2017-01-01 12:44 ` Grygorii Maistrenko
2017-01-04 15:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223190023.GA9644@lp-laptop-d \
--to=grygoriimkd@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).