From: Christoph Lameter <cl@linux.com>
To: Grygorii Maistrenko <grygoriimkd@gmail.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] slub: do not merge cache if slub_debug contains a never-merge flag
Date: Sat, 24 Dec 2016 17:09:03 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.20.1612241708280.9536@east.gentwo.org> (raw)
In-Reply-To: <20161223190023.GA9644@lp-laptop-d>
On Fri, 23 Dec 2016, Grygorii Maistrenko wrote:
> > struct kmem_cache *ind_mergeable(size_t size, size_t align,
> > unsigned long flags, const char *name, void (*ctor)(void *))
> > {
> > struct kmem_cache *s;
> >
> > if (slab_nomerge || (flags & SLAB_NEVER_MERGE)) <----- !!!!!!
> > return NULL;
>
> This one check is done on flags passed to kmem_cache_create().
>
> >
> > if (ctor)
> > return NULL;
> >
> > size = ALIGN(size, sizeof(void *));
> > align = calculate_alignment(flags,
> flags = kmem_cache_flags(size, flags, name, NULL);
>
> I added here the missing line. This updates flags from commandline and
> after this we do not check it.
Then please move the check down below the flags update.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-24 23:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 23:59 [PATCH] slub: do not merge cache if slub_debug contains a never-merge flag Grygorii Maistrenko
2016-12-23 18:30 ` Christoph Lameter
2016-12-23 19:00 ` Grygorii Maistrenko
2016-12-24 23:09 ` Christoph Lameter [this message]
2016-12-26 19:08 ` [PATCH v2] " Grygorii Maistrenko
2016-12-27 9:50 ` Pekka Enberg
2016-12-28 0:17 ` David Rientjes
2017-01-01 12:44 ` Grygorii Maistrenko
2017-01-04 15:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612241708280.9536@east.gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=grygoriimkd@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).