* [PATCH] mm: testcases for RODATA: fix config dependency
@ 2017-02-09 13:16 Jinbum Park
2017-02-10 23:36 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Jinbum Park @ 2017-02-09 13:16 UTC (permalink / raw)
To: akpm; +Cc: keescook, valentinrothberg, linux-mm, linux-kernel
Since DEBUG_RODATA has renamed to STRICT_KERNEL_RWX,
Fix the config dependency.
Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
---
mm/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
index 3e5eada..3c88b7e 100644
--- a/mm/Kconfig.debug
+++ b/mm/Kconfig.debug
@@ -93,7 +93,7 @@ config DEBUG_PAGE_REF
config DEBUG_RODATA_TEST
bool "Testcase for the marking rodata read-only"
- depends on DEBUG_RODATA
+ depends on STRICT_KERNEL_RWX
---help---
This option enables a testcase for the setting rodata read-only.
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mm: testcases for RODATA: fix config dependency
2017-02-09 13:16 [PATCH] mm: testcases for RODATA: fix config dependency Jinbum Park
@ 2017-02-10 23:36 ` Kees Cook
2017-02-15 21:00 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2017-02-10 23:36 UTC (permalink / raw)
To: Jinbum Park, Andrew Morton
Cc: Valentin Rothberg, Linux-MM, LKML, Laura Abbott
On Thu, Feb 9, 2017 at 5:16 AM, Jinbum Park <jinb.park7@gmail.com> wrote:
> Since DEBUG_RODATA has renamed to STRICT_KERNEL_RWX,
> Fix the config dependency.
>
> Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
> Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
> ---
> mm/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 3e5eada..3c88b7e 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -93,7 +93,7 @@ config DEBUG_PAGE_REF
>
> config DEBUG_RODATA_TEST
> bool "Testcase for the marking rodata read-only"
> - depends on DEBUG_RODATA
> + depends on STRICT_KERNEL_RWX
> ---help---
> This option enables a testcase for the setting rodata read-only.
Great, thanks!
Acked-by: Kees Cook <keescook@chromium.org>
Andrew, do you want to take this patch, since it applies on top of
"mm: add arch-independent testcases for RODATA", or do you want me to
take both patches into my KSPP tree which has the DEBUG_RODATA ->
STRICT_KERNEL_RWX renaming series?
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: testcases for RODATA: fix config dependency
2017-02-10 23:36 ` Kees Cook
@ 2017-02-15 21:00 ` Andrew Morton
2017-02-15 22:12 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2017-02-15 21:00 UTC (permalink / raw)
To: Kees Cook; +Cc: Jinbum Park, Valentin Rothberg, Linux-MM, LKML, Laura Abbott
On Fri, 10 Feb 2017 15:36:37 -0800 Kees Cook <keescook@chromium.org> wrote:
> > config DEBUG_RODATA_TEST
> > bool "Testcase for the marking rodata read-only"
> > - depends on DEBUG_RODATA
> > + depends on STRICT_KERNEL_RWX
> > ---help---
> > This option enables a testcase for the setting rodata read-only.
>
> Great, thanks!
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> Andrew, do you want to take this patch, since it applies on top of
> "mm: add arch-independent testcases for RODATA", or do you want me to
> take both patches into my KSPP tree which has the DEBUG_RODATA ->
> STRICT_KERNEL_RWX renaming series?
I staged this and mm-add-arch-independent-testcases-for-rodata.patch
after linux-next and shall merge them after the STRICT_KERNEL_RWX
rename has gone into mainline.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: testcases for RODATA: fix config dependency
2017-02-15 21:00 ` Andrew Morton
@ 2017-02-15 22:12 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2017-02-15 22:12 UTC (permalink / raw)
To: Andrew Morton
Cc: Jinbum Park, Valentin Rothberg, Linux-MM, LKML, Laura Abbott
On Wed, Feb 15, 2017 at 1:00 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Fri, 10 Feb 2017 15:36:37 -0800 Kees Cook <keescook@chromium.org> wrote:
>
>> > config DEBUG_RODATA_TEST
>> > bool "Testcase for the marking rodata read-only"
>> > - depends on DEBUG_RODATA
>> > + depends on STRICT_KERNEL_RWX
>> > ---help---
>> > This option enables a testcase for the setting rodata read-only.
>>
>> Great, thanks!
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> Andrew, do you want to take this patch, since it applies on top of
>> "mm: add arch-independent testcases for RODATA", or do you want me to
>> take both patches into my KSPP tree which has the DEBUG_RODATA ->
>> STRICT_KERNEL_RWX renaming series?
>
> I staged this and mm-add-arch-independent-testcases-for-rodata.patch
> after linux-next and shall merge them after the STRICT_KERNEL_RWX
> rename has gone into mainline.
Awesome, thanks!
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-15 22:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 13:16 [PATCH] mm: testcases for RODATA: fix config dependency Jinbum Park
2017-02-10 23:36 ` Kees Cook
2017-02-15 21:00 ` Andrew Morton
2017-02-15 22:12 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).