linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch -mm] mm, vmstat: suppress pcp stats for unpopulated zones in zoneinfo
Date: Mon, 6 Mar 2017 14:11:42 -0800	[thread overview]
Message-ID: <20170306141142.f3b22bc0ba43814f546bf3a0@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.10.1703061400500.46428@chino.kir.corp.google.com>

On Mon, 6 Mar 2017 14:03:32 -0800 (PST) David Rientjes <rientjes@google.com> wrote:

> After "mm, vmstat: print non-populated zones in zoneinfo", /proc/zoneinfo 
> will show unpopulated zones.
> 
> The per-cpu pageset statistics are not relevant for unpopulated zones and 
> can be potentially lengthy, so supress them when they are not interesting.
> 
> Also moves lowmem reserve protection information above pcp stats since it 
> is relevant for all zones per vm.lowmem_reserve_ratio.

Well it's not strictly back-compatible, but /proc/zoneinfo is such a
mess that parsers will be few and hopefully smart enough to handle
this.

btw,

  pagesets
    cpu: 0
              count: 118
              high:  186
              batch: 31
  vm stats threshold: 72
    cpu: 1
              count: 53
              high:  186
              batch: 31
  vm stats threshold: 72

Should the "vm stats threshold" thing be indented further?

Do we need to print it out N times anyway?  Can different CPUs have
different values?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-03-06 22:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 23:26 [patch] mm, zoneinfo: print non-populated zones David Rientjes
2017-03-03 13:35 ` Anshuman Khandual
2017-03-03 22:46   ` David Rientjes
2017-03-03 22:53     ` [patch v2] mm, vmstat: print non-populated zones in zoneinfo David Rientjes
2017-03-04  8:21       ` Anshuman Khandual
2017-03-06 22:03       ` [patch -mm] mm, vmstat: suppress pcp stats for unpopulated " David Rientjes
2017-03-06 22:11         ` Andrew Morton [this message]
2017-03-08 14:42       ` [patch v2] mm, vmstat: print non-populated " Michal Hocko
2017-03-17  8:57         ` Michal Hocko
2017-03-17 21:21           ` David Rientjes
2017-05-03 23:41       ` [PATCH] mm, vmstat: Remove spurious WARN() during zoneinfo print Reza Arbab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170306141142.f3b22bc0ba43814f546bf3a0@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).