From: David Rientjes <rientjes@google.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, zoneinfo: print non-populated zones
Date: Fri, 3 Mar 2017 14:46:03 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1703031445340.92298@chino.kir.corp.google.com> (raw)
In-Reply-To: <4acf16c5-c64b-b4f8-9a41-1926eed23fe1@linux.vnet.ibm.com>
On Fri, 3 Mar 2017, Anshuman Khandual wrote:
> > This patch shows statistics for non-populated zones in /proc/zoneinfo.
> > The zones exist and hold a spot in the vm.lowmem_reserve_ratio array.
> > Without this patch, it is not possible to determine which index in the
> > array controls which zone if one or more zones on the system are not
> > populated.
>
> Right, its a problem when it does not even display array elements with
> an index value associated with it. But changing the array display will
> break the interface where as displaying non populated zones in the
> /proc/zoneinfo does not break anything.
>
Precisely.
> The name of the Boolean "populated" is bit misleading IMHO. What I think you
> want here is to invoke the callback if the zone is populated as well as this
> variable is true. The variable can be named something like 'assert_populated'.
>
I like it, I'll send a v2. Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-03 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 23:26 [patch] mm, zoneinfo: print non-populated zones David Rientjes
2017-03-03 13:35 ` Anshuman Khandual
2017-03-03 22:46 ` David Rientjes [this message]
2017-03-03 22:53 ` [patch v2] mm, vmstat: print non-populated zones in zoneinfo David Rientjes
2017-03-04 8:21 ` Anshuman Khandual
2017-03-06 22:03 ` [patch -mm] mm, vmstat: suppress pcp stats for unpopulated " David Rientjes
2017-03-06 22:11 ` Andrew Morton
2017-03-08 14:42 ` [patch v2] mm, vmstat: print non-populated " Michal Hocko
2017-03-17 8:57 ` Michal Hocko
2017-03-17 21:21 ` David Rientjes
2017-05-03 23:41 ` [PATCH] mm, vmstat: Remove spurious WARN() during zoneinfo print Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1703031445340.92298@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).