* [PATCH] mm/vmalloc: terminate searching since one node found
@ 2017-07-16 7:28 Zhaoyang Huang
2017-07-17 7:00 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Zhaoyang Huang @ 2017-07-16 7:28 UTC (permalink / raw)
To: zhaoyang.huang, Andrew Morton, Michal Hocko, Ingo Molnar,
zijun_hu, Vlastimil Babka, Thomas Garnier, Kirill A. Shutemov,
Andrey Ryabinin, linux-mm, linux-kernel
It is no need to find the very beginning of the area within
alloc_vmap_area, which can be done by judging each node during the process
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
Signed-off-by: Zhaoyang Huang <huangzhaoyang@gmail.com>
---
mm/vmalloc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 34a1c3e..f833e07 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -459,9 +459,16 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
while (n) {
struct vmap_area *tmp;
+ struct vmap_area *tmp_next;
tmp = rb_entry(n, struct vmap_area, rb_node);
+ tmp_next = list_next_entry(tmp, list);
if (tmp->va_end >= addr) {
first = tmp;
+ if (ALIGN(tmp->va_end, align) + size
+ < tmp_next->va_start) {
+ addr = ALIGN(tmp->va_end, align);
+ goto found;
+ }
if (tmp->va_start <= addr)
break;
n = n->rb_left;
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/vmalloc: terminate searching since one node found
2017-07-16 7:28 [PATCH] mm/vmalloc: terminate searching since one node found Zhaoyang Huang
@ 2017-07-17 7:00 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2017-07-17 7:00 UTC (permalink / raw)
To: Zhaoyang Huang
Cc: zhaoyang.huang, Andrew Morton, Ingo Molnar, zijun_hu,
Vlastimil Babka, Thomas Garnier, Kirill A. Shutemov,
Andrey Ryabinin, linux-mm, linux-kernel
On Sun 16-07-17 15:28:27, Zhaoyang Huang wrote:
> It is no need to find the very beginning of the area within
> alloc_vmap_area, which can be done by judging each node during the process
Please describe _why_ the patch is needed. I suspect this is an
optimization but for which workloads it matters and how much.
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
> Signed-off-by: Zhaoyang Huang <huangzhaoyang@gmail.com>
no need to to make your s-o-b twice. Just use the same one as the From
(author of the patch).
> ---
> mm/vmalloc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 34a1c3e..f833e07 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -459,9 +459,16 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
>
> while (n) {
> struct vmap_area *tmp;
> + struct vmap_area *tmp_next;
> tmp = rb_entry(n, struct vmap_area, rb_node);
> + tmp_next = list_next_entry(tmp, list);
> if (tmp->va_end >= addr) {
> first = tmp;
> + if (ALIGN(tmp->va_end, align) + size
> + < tmp_next->va_start) {
> + addr = ALIGN(tmp->va_end, align);
> + goto found;
> + }
> if (tmp->va_start <= addr)
> break;
> n = n->rb_left;
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mm/vmalloc: terminate searching since one node found
@ 2017-07-16 7:23 Zhaoyang Huang
0 siblings, 0 replies; 3+ messages in thread
From: Zhaoyang Huang @ 2017-07-16 7:23 UTC (permalink / raw)
To: zhaoyang.huang, Andrew Morton, Michal Hocko, Ingo Molnar,
zijun_hu, Vlastimil Babka, Thomas Garnier, Kirill A. Shutemov,
Andrey Ryabinin, linux-mm, linux-kernel
From: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com:wq>
It is no need to find the very beginning of the area within
alloc_vmap_area, which can be done by judging each node during the process
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
---
mm/vmalloc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 34a1c3e..f833e07 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -459,9 +459,16 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
while (n) {
struct vmap_area *tmp;
+ struct vmap_area *tmp_next;
tmp = rb_entry(n, struct vmap_area, rb_node);
+ tmp_next = list_next_entry(tmp, list);
if (tmp->va_end >= addr) {
first = tmp;
+ if (ALIGN(tmp->va_end, align) + size
+ < tmp_next->va_start) {
+ addr = ALIGN(tmp->va_end, align);
+ goto found;
+ }
if (tmp->va_start <= addr)
break;
n = n->rb_left;
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-17 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-16 7:28 [PATCH] mm/vmalloc: terminate searching since one node found Zhaoyang Huang
2017-07-17 7:00 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2017-07-16 7:23 Zhaoyang Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).