[PATCH] mm: filemap: remove include of hardirq.h

[PATCH] mm: filemap: remove include of hardirq.h

[Yang Shi]

in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
doesn't use in_atomic() directly at all, so it sounds unnecessary to
include hardirq.h.
With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
with allnoconfig.

Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>
---
 mm/filemap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 594d73f..57238f4 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -31,7 +31,6 @@
 #include <linux/blkdev.h>
 #include <linux/security.h>
 #include <linux/cpuset.h>
-#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
 #include <linux/hugetlb.h>
 #include <linux/memcontrol.h>
 #include <linux/cleancache.h>
-- 
1.8.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: filemap: remove include of hardirq.h

[Matthew Wilcox]

On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
> With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
> with allnoconfig.

Wait, what?  How would including an unused header file increase the size
of the final image?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm: filemap: remove include of hardirq.h

[Yang Shi]

On 11/4/17 6:47 AM, Matthew Wilcox wrote:
> On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote:
>> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
>> doesn't use in_atomic() directly at all, so it sounds unnecessary to
>> include hardirq.h.
>> With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
>> with allnoconfig.
> 
> Wait, what?  How would including an unused header file increase the size
> of the final image?

Sorry for the wrong message, I double checked again with building kernel 
a couple of times then comparing the size, there is no change. Will 
remove this from the commit log.

Yang

> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>