From: Nicholas Piggin <npiggin@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH for 4.15 10/14] cpu_opv: Wire up powerpc system call
Date: Tue, 7 Nov 2017 12:21:16 +1100 [thread overview]
Message-ID: <20171107122116.7a75c3a8@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <337041894.6072.1510015637355.JavaMail.zimbra@efficios.com>
On Tue, 7 Nov 2017 00:47:17 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- On Nov 6, 2017, at 7:37 PM, Nicholas Piggin npiggin@gmail.com wrote:
>
> > On Mon, 6 Nov 2017 15:56:40 -0500
> > Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> >
> >> diff --git a/arch/powerpc/include/uapi/asm/unistd.h
> >> b/arch/powerpc/include/uapi/asm/unistd.h
> >> index b1980fcd56d5..972a7d68c143 100644
> >> --- a/arch/powerpc/include/uapi/asm/unistd.h
> >> +++ b/arch/powerpc/include/uapi/asm/unistd.h
> >> @@ -396,5 +396,6 @@
> >> #define __NR_kexec_file_load 382
> >> #define __NR_statx 383
> >> #define __NR_rseq 384
> >> +#define __NR_cpu_opv 385
> >
> > Sorry for bike shedding, but could we invest a few more keystrokes to
> > make these names a bit more readable?
>
> Whenever I try to make variables or function names more explicit, I can
> literally feel my consciousness (taking the form of an angry Peter Zijlstra)
> breathing down my neck asking me to make them shorter. So I guess this is
> where it becomes a question of taste.
Specialist syscall is a bit different than a common function or variable
though.
>
> I think the "rseq" syscall name is short, to the point, and should be mostly
> fine.
I'm not sure if it's really "to the point". I think kexec_file_load
is better than kfload, for example :)
> For "cpu_opv", it was just a short name that fit the bill until a
> better idea would come.
>
> I'm open to suggestions. Any color preference ? ;-)
What can you do within 16 characters?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-07 1:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 9:22 [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Michal Hocko
2017-11-06 17:35 ` Johannes Weiner
2017-11-06 17:57 ` Joe Perches
2017-11-06 18:14 ` Khalid Aziz
2017-11-06 18:18 ` Michal Hocko
2017-11-06 20:17 ` Khalid Aziz
[not found] ` <20171106205644.29386-11-mathieu.desnoyers@efficios.com>
2017-11-07 0:37 ` [RFC PATCH for 4.15 10/14] cpu_opv: Wire up powerpc system call Nicholas Piggin
2017-11-07 0:47 ` Mathieu Desnoyers
2017-11-07 1:21 ` Nicholas Piggin [this message]
2017-11-07 9:06 ` [PATCH] mm, sparse: do not swamp log with huge vmemmap allocation failures Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107122116.7a75c3a8@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=davejwatson@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).