linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [mmotm:master 180/303] arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true'
@ 2017-11-11  7:49 kbuild test robot
  2017-11-14  0:10 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2017-11-11  7:49 UTC (permalink / raw)
  To: Michal Hocko
  Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   21c4efa7694b072dddce68082e16156f24e1c1f0
commit: 224aa5f4017811570da4d0a332d9791da07b2fc7 [180/303] mm: simplify nodemask printing
config: tile-tilegx_defconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 224aa5f4017811570da4d0a332d9791da07b2fc7
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   arch/tile/kernel/setup.c: In function 'setup_isolnodes':
>> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]
>> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]

vim +222 arch/tile/kernel/setup.c

77f8c740 Chris Metcalf 2013-08-06  216  
867e359b Chris Metcalf 2010-05-28  217  static int __init setup_isolnodes(char *str)
867e359b Chris Metcalf 2010-05-28  218  {
867e359b Chris Metcalf 2010-05-28  219  	if (str == NULL || nodelist_parse(str, isolnodes) != 0)
867e359b Chris Metcalf 2010-05-28  220  		return -EINVAL;
867e359b Chris Metcalf 2010-05-28  221  
839b2680 Tejun Heo     2015-02-13 @222  	pr_info("Set isolnodes value to '%*pbl'\n",
839b2680 Tejun Heo     2015-02-13  223  		nodemask_pr_args(&isolnodes));
867e359b Chris Metcalf 2010-05-28  224  	return 0;
867e359b Chris Metcalf 2010-05-28  225  }
867e359b Chris Metcalf 2010-05-28  226  early_param("isolnodes", setup_isolnodes);
867e359b Chris Metcalf 2010-05-28  227  

:::::: The code at line 222 was first introduced by commit
:::::: 839b268033c5d1316b2f8cf49184984e6f335fee tile: use %*pb[l] to print bitmaps including cpumasks and nodemasks

:::::: TO: Tejun Heo <tj@kernel.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16674 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [mmotm:master 180/303] arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true'
  2017-11-11  7:49 [mmotm:master 180/303] arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' kbuild test robot
@ 2017-11-14  0:10 ` Andrew Morton
  2017-11-14  7:01   ` Michal Hocko
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2017-11-14  0:10 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Michal Hocko, kbuild-all, Johannes Weiner, Linux Memory Management List

On Sat, 11 Nov 2017 15:49:04 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   21c4efa7694b072dddce68082e16156f24e1c1f0
> commit: 224aa5f4017811570da4d0a332d9791da07b2fc7 [180/303] mm: simplify nodemask printing
> config: tile-tilegx_defconfig (attached as .config)
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 224aa5f4017811570da4d0a332d9791da07b2fc7
>         # save the attached .config to linux build tree
>         make.cross ARCH=tile 
> 
> All warnings (new ones prefixed by >>):
> 
>    arch/tile/kernel/setup.c: In function 'setup_isolnodes':
> >> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]
> >> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]
> 
> vim +222 arch/tile/kernel/setup.c
> 
> 77f8c740 Chris Metcalf 2013-08-06  216  
> 867e359b Chris Metcalf 2010-05-28  217  static int __init setup_isolnodes(char *str)
> 867e359b Chris Metcalf 2010-05-28  218  {
> 867e359b Chris Metcalf 2010-05-28  219  	if (str == NULL || nodelist_parse(str, isolnodes) != 0)
> 867e359b Chris Metcalf 2010-05-28  220  		return -EINVAL;
> 867e359b Chris Metcalf 2010-05-28  221  
> 839b2680 Tejun Heo     2015-02-13 @222  	pr_info("Set isolnodes value to '%*pbl'\n",
> 839b2680 Tejun Heo     2015-02-13  223  		nodemask_pr_args(&isolnodes));
> 867e359b Chris Metcalf 2010-05-28  224  	return 0;
> 867e359b Chris Metcalf 2010-05-28  225  }
> 867e359b Chris Metcalf 2010-05-28  226  early_param("isolnodes", setup_isolnodes);
> 867e359b Chris Metcalf 2010-05-28  227  

Well that's irritating.  Maybe we can suppress it with some mess
involving builtin_constant_p?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [mmotm:master 180/303] arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true'
  2017-11-14  0:10 ` Andrew Morton
@ 2017-11-14  7:01   ` Michal Hocko
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2017-11-14  7:01 UTC (permalink / raw)
  To: Andrew Morton
  Cc: kbuild test robot, kbuild-all, Johannes Weiner,
	Linux Memory Management List

On Mon 13-11-17 16:10:26, Andrew Morton wrote:
> On Sat, 11 Nov 2017 15:49:04 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > tree:   git://git.cmpxchg.org/linux-mmotm.git master
> > head:   21c4efa7694b072dddce68082e16156f24e1c1f0
> > commit: 224aa5f4017811570da4d0a332d9791da07b2fc7 [180/303] mm: simplify nodemask printing
> > config: tile-tilegx_defconfig (attached as .config)
> > compiler: tilegx-linux-gcc (GCC) 4.6.2
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 224aa5f4017811570da4d0a332d9791da07b2fc7
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=tile 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    arch/tile/kernel/setup.c: In function 'setup_isolnodes':
> > >> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]
> > >> arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' [-Waddress]
> > 
> > vim +222 arch/tile/kernel/setup.c
> > 
> > 77f8c740 Chris Metcalf 2013-08-06  216  
> > 867e359b Chris Metcalf 2010-05-28  217  static int __init setup_isolnodes(char *str)
> > 867e359b Chris Metcalf 2010-05-28  218  {
> > 867e359b Chris Metcalf 2010-05-28  219  	if (str == NULL || nodelist_parse(str, isolnodes) != 0)
> > 867e359b Chris Metcalf 2010-05-28  220  		return -EINVAL;
> > 867e359b Chris Metcalf 2010-05-28  221  
> > 839b2680 Tejun Heo     2015-02-13 @222  	pr_info("Set isolnodes value to '%*pbl'\n",
> > 839b2680 Tejun Heo     2015-02-13  223  		nodemask_pr_args(&isolnodes));
> > 867e359b Chris Metcalf 2010-05-28  224  	return 0;
> > 867e359b Chris Metcalf 2010-05-28  225  }
> > 867e359b Chris Metcalf 2010-05-28  226  early_param("isolnodes", setup_isolnodes);
> > 867e359b Chris Metcalf 2010-05-28  227  
> 
> Well that's irritating.  Maybe we can suppress it with some mess
> involving builtin_constant_p?

http://lkml.kernel.org/r/CAK8P3a36vx6fnXz=QWxqpCb3TC2XZeKLe3Or7Wvrac5=C3RaxA@mail.gmail.com
?

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-14  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11  7:49 [mmotm:master 180/303] arch/tile/kernel/setup.c:222:2: warning: the address of 'isolnodes' will always evaluate as 'true' kbuild test robot
2017-11-14  0:10 ` Andrew Morton
2017-11-14  7:01   ` Michal Hocko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).