From: Michal Hocko <mhocko@kernel.org>
To: JianKang Chen <chenjiankang1@huawei.com>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xieyisheng1@huawei.com,
guohanjun@huawei.com, wangkefeng.wang@huawei.com
Subject: Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages
Date: Wed, 29 Nov 2017 17:04:46 +0100 [thread overview]
Message-ID: <20171129160446.jluzpv3n6mjc3fwv@dhcp22.suse.cz> (raw)
In-Reply-To: <20171127113341.ldx32qvexqe2224d@dhcp22.suse.cz>
On Mon 27-11-17 12:33:41, Michal Hocko wrote:
> On Mon 27-11-17 19:09:24, JianKang Chen wrote:
> > From: Jiankang Chen <chenjiankang1@huawei.com>
> >
> > __get_free_pages will return an virtual address,
> > but it is not just 32-bit address, for example a 64-bit system.
> > And this comment really confuse new bigenner of mm.
>
> s@bigenner@beginner@
>
> Anyway, do we really need a bug on for this? Has this actually caught
> any wrong usage? VM_BUG_ON tends to be enabled these days AFAIK and
> panicking the kernel seems like an over-reaction. If there is a real
> risk then why don't we simply mask __GFP_HIGHMEM off when calling
> alloc_pages?
I meant this
---
next prev parent reply other threads:[~2017-11-29 16:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:09 [PATCH resend] mm/page_alloc: fix comment is __get_free_pages JianKang Chen
2017-11-27 11:33 ` Michal Hocko
2017-11-29 16:04 ` Michal Hocko [this message]
2017-11-29 21:41 ` Andrew Morton
2017-11-30 6:53 ` Michal Hocko
2017-11-30 21:17 ` Andrew Morton
2017-12-01 7:24 ` Michal Hocko
2017-12-01 11:18 ` Michal Hocko
2017-12-14 14:06 ` Michal Hocko
2017-12-14 20:33 ` Andrew Morton
2017-12-15 9:36 ` Michal Hocko
2017-12-15 20:57 ` Andrew Morton
2017-12-16 11:52 ` Michal Hocko
2018-04-06 10:02 ` Michal Hocko
2018-04-06 19:58 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2017-11-25 7:20 JianKang Chen
2017-11-27 6:22 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129160446.jluzpv3n6mjc3fwv@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chenjiankang1@huawei.com \
--cc=guohanjun@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=wangkefeng.wang@huawei.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).